Closed
Bug 869513
Opened 12 years ago
Closed 12 years ago
Consider moving /login page to Fireplace
Categories
(Marketplace Graveyard :: Consumer Pages, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cvan, Unassigned)
References
()
Details
(Whiteboard: [fireplace])
When users are not logged in we redirect them to https://marketplace-altdev.allizom.org/login
For example, as an anonymous user, try to access https://marketplace-altdev.allizom.org/reviewers
Unfortunately, Zamboni consumer pages is serving that. We should try to get that page served by Fireplace so we don't have to worry about maintaining the templates, CSS, and JS for that page in Zamboni:
http://f.cl.ly/items/4325201f1V0Q0B2M3C1V/Screen%20Shot%202013-05-07%20at%209.35.34%20AM.png
And it'll look prettier in Fireplace.
Related: 500s look like this with on -altdev because Zamboni, not Fireplace, is serving the template:
http://f.cl.ly/items/451i0s0R0x2A293Q3c3q/Screen%20Shot%202013-05-07%20at%209.36.58%20AM.png
Comment 1•12 years ago
|
||
We can't use fireplace for login to those pages because fireplace's login token doesn't start a django season. We'd need to make a page styled like fireplace but that doesn't run any of the JS.
Comment 2•12 years ago
|
||
And by season, my autocorrect means session.
Comment 3•12 years ago
|
||
Is storing sessions in the database (maybe in redis) feasible here? That might help us share user sessions among zamboni and fireplace instances. Thoughts?
Comment 4•12 years ago
|
||
(In reply to Ashish Dubey [:ashish_d] from comment #3)
> Is storing sessions in the database (maybe in redis) feasible here? That
> might help us share user sessions among zamboni and fireplace instances.
> Thoughts?
I think the end goal would be to move more apps to SSA and away from server-side sessions. That way, we can move towards using the API like Fireplace is using it.
I'm inclined to WONTFIX this bug in favor of client-siding all of the components in Zamboni (as was discussed on https://etherpad.mozilla.org/marketplace-debt).
Comment 5•12 years ago
|
||
WONTFIXing. As we port everything to use the new commonplace login.js, this will fix itself automatically.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•