86959 - win32 installer needs to log additional data

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[Sean Su]

The installer needs to log the following 2 additional data points:
 * which type of protocol the user is using to download the bits: HTTP vs FTP
 * how many "hang" problems each file encountered

This information needs to be part of the data stream that gets sent back 
netscape.com for error analysis.

Mozilla has this feature disabled, while ns has it enabled.  This bug needs to 
be fixed in the mozilla side, thus filed in bugzilla.

I recommend that this be added for RTM due to the current host of download 
issues we're seeing with the beta1 bits.

Comment 1

[Sean Su]

Pdt has approved this bug for asap.

Request from pdt: also include info on whether turbo was selected or not.

Comment 2

[Sean Su]

updating summary to reflect more than 2 data info

Comment 3

[selmer (gone)]

pdt+

Comment 4

[selmer (gone)]

any update?

Comment 5

[selmer (gone)]

Sorry for the spam, I need to commit a change here to try to catch bugzilla with
an infinite throbber...

Comment 6

[Sean Su]

I have 1 of the 3 data info done.  It's on hold right now because I have other 
higher priority bugs to deal with right now.  I'll keep you posted.

Comment 7

[Sean Su]

Attachment: patch #1

Comment 8

[Samir Gehani]

Comments as I review the code with Sean:

1> Change nsSocket::Recv() to nothardcode the new timeoutr value; pass it in
from the overloaded nsSocket::Recv().

2> Be more descriptive when logging download status in install_status.log:
e.g. from xpcom=<x>,<y>,<z> to xpcom=NetRetries:<x>,CRCRetries:<y>,NetTimeouts:<z>

Comment 9

[Sean Su]

Attachment: patch #2 with samir's comments taken into account.

Comment 10

[Samir Gehani]

r=sgehani

Comment 11

[Sean Su]

adding keywords to make sure this is picked up by pdt searches.

Comment 12

[Scott MacGregor]

rs=mscott

Comment 13

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 14

[Sean Su]

fix checked in.  I don't think you'll be able to fully verify this bug.  You can 
verify one part of it by installing the browser, and look at install_status.log 
in the destination folder.

It should contain new information like such:

  Turbo Mode: false

  Download protocol: FTP

  Download status: ok
      Mozilla XPCOM: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      Navigator: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      Mail & News: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      Personal Security Manager: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      mozilla.org Uninstaller: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      Chatzilla: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      US English profile defaults: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      English (US) language pack: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      US region pack: NetRetries:0, CRCRetries:0, NetTimeOuts:0
      Quality Feedback Agent: NetRetries:0, CRCRetries:0, NetTimeOuts:0

The other part of the bug is that this new info is sent back to netscape.com.  
Mozilla builds have this feature disabled at the moment, while ns builds have it 
on.

Comment 15

[Sean Su]

really marking this fixed.

Comment 16

[Grace Bush]

verified with build 2001071005 branch
install log/ reports 
adding vtrunk (reminder to check trunk builds)

Comment 17

[Grace Bush]

verified in trunk build 2001081405