869755 - [Dialer] Cannot delete all logs in call log

Status: RESOLVED DUPLICATE of bug 873466

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Leo]

1. Title : Cannot delete all logs in call log
2. Precondition : Connect multi call >> Switch call >> End all calls >> Enter call log
3. Tester's Action : Delete all logs
4. Detailed Symptom : Some logs remain
5. Expected : Can delete all logs
6. Reproducibility: Y
1) Frequency Rate : sometimes
7. Gaia Master/v1-train : Reproduced
8. Gaia Revision : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
9 Personal email id : [e-mail]

Comment 1

[Leo]

Attachment: Cannot delete all logs

Comment 2

[Tony Chung [:tchung]]

(In reply to Leo from comment #1)
> Created attachment 746722 [details]
> Cannot delete all logs

can you reproduce this again, this time try and record the logcat of the activity?  also, do you know the gecko changeset you have running on this?

Comment 3

[Leo]

Attachment: adb_log

Gecko revision : 950b402b6188bb2f3ce3176e620ed5249719d720

Comment 4

[Wayne Chang [:wchang]]

Hi Leo, can you let us know if the remaining call logs can never be deleted or do they get deleted when you attempt to 'delete all' again?

Hi Etienne, can you suggest someone to look at this issue? logs are attached.

Comment 5

[Leo]

I tried serveral times, Remaining logs can't be deleted again. 
Only logs can be deleted by "Factory reset"

Comment 6

[Alex Keybl [:akeybl]]

we suspect this is related to multi-calls, we'll need to find an assignee

Comment 7

[Etienne Segonzac (:etienne)]

The call log is being refactored (bug 847406, leo+ too).
We should test this again when it lands.

Comment 8

[Evan Tseng [:evanxd]]

Attachment: Root cause adb log

Comment 9

[Evan Tseng [:evanxd]]

Attachment: Root cause console log

Comment 10

[Evan Tseng [:evanxd]]

Hi all,

You could see the log files "Root cause adb log" and "Root cause console log".

In the "Root cause console log" file, we could found out that
when user picked up a call and held a call, after ringed off one of these two calls and 
the handleEvent() function in handled_call.js was triggered with receiving the "connected" message.

So the connected() function of the HandledCall object was triggered for two times. And the bug was happend.

Comment 11

[Evan Tseng [:evanxd]]

I think is might be also a Gecko bug.

Bug I have a patch could fix the bug before the Gecko bug is resolved.

I think we could use the patch to fix this bug first, and create another bug for the Gecko issue.

How do you guys think?

Comment 12

[Evan Tseng [:evanxd]]

Attachment: Point to the GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/9695

Hi Etienne,

Please help me review the patch.

Thanks. :)

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Evan Tseng [:evanxd] from comment #11)
> I think is might be also a Gecko bug.

Please file a bug if there is a bug. Thanks.

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 748400 [details]
Point to the GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/9695

Well, the incoming and outgoing calls all go through this, so we can't do that.

That said, the underlying data backend changed and is currently in review.
So as I said in Comment 7 we should wait for the refactoring to land first.

Comment 15

[Evan Tseng [:evanxd]]

Hi Etienne,

I got it.

I made the patch because I found out a issue might be related with Gecko.

I'll wait for the refactoring to land first, and check this bug.

Thanks. :)

Comment 16

[Evan Tseng [:evanxd]]

Hi Etienne,

After the patch in Bug 847406 was landed, I tested this bug and I found out that the bug was also resolved.

So we could close this bug.

Thanks. :)