86979 - "launch file" after downloading does not honor OS file associations

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jesse Ruderman]

When I download a zipped nightly, Mozilla helpfully includes a "launch file"
option in the download dialog after the download is complete.  However, clicking
"launch file" opens WinZip, even though I have .zip files associated with
FreeZip.  This results in WinZip telling me that WinZip is not associated with
zip files.

(Fwiw, IE has a similar feature that screws up in a different way: it launches
FreeZip, but in the wrong directory, so the contents of the zip file end up in
the wrong place.)

Windows NT 4.0, Mozilla 2001 061804.

Comment 1

[sairuh (rarely reading bugmail)]

see also bug 87218, which is kinda like the opposite of this one: user-define
setting in Netscape6.x are clobbered by OS setting.

Comment 2

[sairuh (rarely reading bugmail)]

nominate for limbo release.

Comment 3

[Scott MacGregor]

Launch file relies on the windows shell to figure out what application is bound
to .zip files. Free zip apparently did not poke your registery settings to be
the windows handler for .zip files. 

Comment 4

[Jesse Ruderman]

If I double-click on a .zip file in the explorer shell, FreeZip opens and
immediately unzips the file into the same directory.  mscott, are you saying
that there are multiple registry settings needed to fully associate file types,
and FreeZip is missing one of them?

Comment 5

[Scott MacGregor]

wow, that's fascinating. A double click in explorere launches free zip but the
launch button in mozilla launches winzip? Hmm, I'm at a loss to explain that
because the launch button just tells the explorere shell to simulate a double
click of the file:

nsLocalFile::Launch is defined as:
  // use the app registry name to launch a shell execute....
  LONG r = (LONG) ::ShellExecute( NULL, "open", (const char *) path, NULL, NULL,
SW_SHOWNORMAL);

Comment 6

[basic]

Build 2001061804
It would seem that Mozilla is not using the "default" action to open the zip file. 
It looks for an action called "open", which Freezip doesn't do.

Freezip's default action is called "unzip". Winzip's default action is "open"
and somehow (don't ask me how) zip files are still associated to winzip (if you
check in Window's 'Folder Options'->'File Types' you will find that Winzip's
default extension is .zip and freezip's default extension is also .zip).

I wasn't able reproduce this bug as (in the build I'm using) "Launch File" is
disabled. Will test again when I get a new build

Comment 7

[basic]

Confirmed in Build 2001062204

Mozilla is actually using 'open' rather than the default 'unzip'.

so the "open" in nsLocalFile::Launch needs to be some value gotten from the
registry that's the default?

for freezip it would be in HKEY_CLASSES_ROOT\freezip\Shell\(Default)

Comment 8

[Jesse Ruderman]

We currently pass "open" as the second parameter to ShellExectue.  According to 
http://msdn.microsoft.com/library/psdk/shellcc/shell/Functions/ShellExecute.htm,
we should be passing in NULL, which does the following:

        * For systems prior to Microsoft Windows 2000, the default verb is used
if it is valid and available in the registry. If not, the "open" verb is used.

        * For Windows 2000 and later systems, the default verb is used if
available. If not, the "open" verb is used. If neither verb is available, the
system uses the first verb listed in the registry.

Comment 9

[Manoj]

Mozilla Build id: 2001 060703

There are occassions when the Launch File button does not get enabled after the
download has completed. The button's enabling is flaky at best, I just
downloaded a file and the Launch button didn't get enabled...

http://www.rpi.edu/~mehtamr/Resume.rtf

Comment 10

[basic]

This should be an easy fix.

Comment 11

[Blake Ross]

Fix checked in.

Comment 12

[Jesse Ruderman]

*** Bug 106151 has been marked as a duplicate of this bug. ***

Comment 13

[Jesse Ruderman]

I don't think this was ever fixed.  It's still broken for me, and I still 
see "open" in the code.

Comment 14

[basic]

Attachment: patch (not tested)

Comment 15

[Blake Ross]

mscott, sr=?

Comment 16

[Blake Ross]

tested, worksforme, got r=ben sr=hewitt, checked in.

Comment 17

[Jesse Ruderman]

I can't verify this fix because the "launch file" button is now disabled for zip
files :(

Comment 18

[sairuh (rarely reading bugmail)]

tested using 2002.07.23.08-1.0 comm branch bits on win2k.

true, in the progress dlg the "launch file" button is disabled...however, in the
download manager window, i can select the entry for the .zip file i downloaded,
and the "launch file" button there is enabled and does work.

i'll give this an rs vrfy. if there's a seperate issue with "launch file" being
disabled in the progress dlg, it might be better to track it seperately...