thunderbird should declare itself dpiAware on windows via the .exe manifest

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
OS Integration
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Depends on: 1 bug)

22 Branch
Thunderbird 23.0
x86
Windows 7

Thunderbird Tracking Flags

(thunderbird22 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In bug 866365, we removed the call to SetProcessDPIAware from XRE_mainInit(), and instead added the dpiAware element to firefox.exe's manifest. (This is the MS recommended way for an application to declare itself dpi-aware, as per MSDN documentation.)

So to maintain its existing behavior on hi-dpi windows systems, thunderbird should make the same manifest addition. Bug 866365 is likely to be uplifted to mozilla-22, I think, so that's also where the manifest change should be made.
(Assignee)

Updated

4 years ago
Depends on: 866365
(Assignee)

Comment 1

4 years ago
Created attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest
Attachment #746893 - Flags: review?(mbanner)
(Assignee)

Updated

4 years ago
Assignee: nobody → jfkthame
Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

Not tested, but looks fine as a copy of what was landed for FF. r=Standard8.
Attachment #746893 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/comm-central/rev/f85134b411f6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
(Assignee)

Comment 4

4 years ago
Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

[Approval Request Comment]

See bug 866365 comment 46. The change there has just landed on Aurora, so the matching thunderbird change also needs to be uplifted.
Attachment #746893 - Flags: approval-mozilla-aurora?
Attachment #746893 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

[Triage Comment]
The core patch is on beta now, post merges, so we'll take this on beta as well.
Attachment #746893 - Flags: approval-comm-aurora? → approval-comm-beta+
https://hg.mozilla.org/releases/comm-beta/rev/e3ed50e2cc6d
status-thunderbird22: --- → fixed
You need to log in before you can comment on or make changes to this bug.