86995 - Menu item View|Headers|All doesn't work should be removed

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[esther]

The menu item View|Headers|All doesn't work (bug 74651) and can't be fixed at
this time so we should take the menu out.  
This menu item is in 3-Pane window mail window and the stand alone message window.

Comment 1

[esther]

adding nsbeta1+ because the original bug 73413 can't be fixed at this time.  

Comment 2

[Håkan Waara]

Attachment: fix

Comment 3

[Håkan Waara]

Would it make sense to hide the whole View > Headers submenu too, since now when
it will only be one item, you have nothing to choose between anyway?

Comment 4

[jglick]

Yeah.  Having View-->Headers-->Normal seems sorta silly.  :-)

Comment 5

[Ninoschka Baca]

If View|Headers|Brief could be implemented (bug# 60207) then View|Headers should 
remain. 

Comment 6

[Håkan Waara]

Nbaca, it's the same situation as with the All Headers thing - as long as there
is no implementation, let's remove it.

I'll post a patch which removes the Headers menu and it's subitems altogether.
Hoping to get this into 0.9.2 to prevent even more dups about All Headers not
working.

Comment 7

[(not reading, please use [e-mail] instead)]

taking my bug back.  

hold off on this, until some final decisions are made.

(if we end up going with your patch, I'll give this bug back to you.)

if you've got cycles, look into implementing All Headers (or Brief Headers),
instead  of ripping out the UI.

Comment 8

[Håkan Waara]

Attachment: oh well, here's the patch to remove the Header menu.

Comment 9

[Håkan Waara]

Sspitzer, what's the point of having unimplemented things visible? It only
spawns duplicate bugs and confusion.

Comment 10

[Håkan Waara]

FYI, Brief Headers is implemented in prass's patch in the bug about msgheaders
not persisting.

Comment 11

[scottputterman]

After discussing this yesterday, there isn't going to be a push to get View All
into the build, so taking it out is a good solution. I don't know how close
Prassanna's fix is.  If it's the correct one then perhaps we should try to get
that in and put brief in the menus and remove all.  If it's not the correct fix,
I'd do what hwaara is doing.

Comment 12

[Håkan Waara]

It's easy to checkin this code again once it's usable - when prassana gets the
code in or some yet unknown person fixes All Headers.

This is naturally temporary.

Comment 13

[(not reading, please use [e-mail] instead)]

here's what I think we should do:

you know that twisty in the headers area that turn the normal view into the
brief view?  (I'll attach a screen shot.)

View | Headers | Brief should be added and hooked up to that.

View | Headers | All should be removed until it works.

the View | Headers menu item should not go away.

Comment 14

[(not reading, please use [e-mail] instead)]

it looks like prass has a patch for the first half of this problem in bug #74139

(adding View |Headers | Brief)

it makes more sense to work on getting that in and then removing "View | 
Headers | All" (until it works)

sounds like mscott has this under control.  re-assing to him.

let's do the right thing.

Comment 15

[Håkan Waara]

Yeah, fixing this the right way is preferred and much better. 

Can we get in the msg persistance from prass's patch at the same time? I've been
waiting very long for that!

Comment 16

[Ninoschka Baca]

Interesting...View|Headers|All effects the body of the message.

- With View|Headers|All selected, create and send a message back to yourself.
- Retrive the message, select the message, select the Forward button

Actual Results: Notice that the headers display more information such as Message 
ID. Close the message without saving the contents. Select View|Headers|Normal, 
select the Forward button again and now the headers displays a shorter header 
(aka Normal header)

Comment 17

[jglick]

Is it supposed to work this way?  I would think the Forwards would look the 
same.

Comment 18

[Ninoschka Baca]

I agree but was not sure so that is why I entered the information here because
some people might call this a "Feature".

Comment 19

[Bob Jacobson]

View Headers All is necessary for identifying sources of spam and reporting them
to ISPs.

Also, View Headers All (on Mac) does work in the Forward Mail display.

Comment 20

[scottputterman]

I'm going to mark this wontfix and instead keep the implement view all headers
bug around.

Comment 21

[Ninoschka Baca]

Bug# 73413 is suppose to fix the problem with View All Headers not working.
Since it is marked for 9.5, shouldn't this menu item be removed?

Marking nsbranch to reconsider removing this menu item since it doesn't appear
that it's going to work for EMojo.

Comment 22

[Håkan Waara]

I posted a patch 'couple of months ago.

I'm not sure why this was wontfixed whilst the other bug keeps idling.

Comment 23

[Ninoschka Baca]

Reopening because the View|All Headers Item should be removed if bug# 73413 is
not going to be fixed soon. 

Comment 24

[Ninoschka Baca]

mscott stated that if there is time then the View|Headers menu item will be
removed . The entire Headers menu item would be removed since it would be silly
to have one item available, that being "Normal".

Comment 25

[Scott MacGregor]

triaging.

Comment 26

[Scott MacGregor]

not a stop ship bug but i'm willing to take a patch for it. 

Comment 27

[Håkan Waara]

mscott, patch is still attached. Can you please review it if you are interested?
  Thanks.

Comment 28

[Scott MacGregor]

triaging. I'm still hopeful we'll get around to implementing view all headers so
this won't be necessary.

Comment 29

[scottputterman]

I'm going to move this to 1.0 with the hope that we fix View All Headers and
make this Won't Fix.  If by the time 1.0 ships we haven't done that then we
should remove the item.

Comment 30

[scottputterman]

marking invalid.  It's in the tree now so no need to remove the menuitem.

Comment 31

[Olga]

Verified.