870056 - Enable testClearPrivateData

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

Robocop test testClearPrivateData was disabled while investigating Panda instability. We should enable it now.

Unfortunately, there were changes to the menu structure while it was disabled -- we need to accommodate those changes.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: enable testClearPrivateData

On tablets, Clear Private Data is in a Privacy and Security section now. We need to select the section, then the item. 

While I was at it, I increased the max wait time for the notification; this allows the test to pass on my Galaxy S, for the first time ever (see bug 837274).

https://tbpl.mozilla.org/?tree=Try&rev=accfdbb77986

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 747080 [details] [diff] [review]
enable testClearPrivateData

Review of attachment 747080 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tests/testClearPrivateData.java.in
@@ +34,4 @@
>          mAsserter.ok(mSolo.searchButton("Clear data"),"checking clear button","clear button exists");
>          mSolo.clickOnButton("Clear data");
> +        // TODO: extra long wait here for bug 837274
> +        mAsserter.is(mSolo.waitForText("Private data cleared", 0, 60000),true,"private data cleared successfully");

I really don't like this 60 second wait, but I do like tests that work!

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c51eab92e5cb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c51eab92e5cb

Comment 5

[Geoff Brown [:gbrown]]

Attachment: (2) Follow-up: use BaseTest.mDevice and selectSettingsItem()

The first patch introduced some utilities in BaseTest; this patch uses those changes to clean up some other tests.

Try run is a little disappointing, but I think the failures are just existing issues: https://tbpl.mozilla.org/?tree=Try&rev=a4dfd8c56685

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 747958 [details] [diff] [review]
(2) Follow-up: use BaseTest.mDevice and selectSettingsItem()

Review of attachment 747958 [details] [diff] [review]:
-----------------------------------------------------------------

do we have a try run with a handful of retriggers?  some of these tests are changing enough that I would like some assurance this is not making it worse.

Comment 7

[Geoff Brown [:gbrown]]

There is a try run shown in Comment 5, and here's another: https://tbpl.mozilla.org/?tree=Try&rev=52fc4b3050cb. I think the patch is OK, but rc2 is not reliable enough right now to get a reassuring try run. I will not land this just yet.

Comment 8

[Geoff Brown [:gbrown]]

https://tbpl.mozilla.org/?tree=Try&rev=9e4cfc429deb looks good now.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d741cce312b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d741cce312b