870167 - Create a mini test framework for Web Audio

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

This is long overdue.  My goals are to stop repeating the same code over and over again, make it easier to add new tests, and make it very easy to run most of our tests work with OfflineAudioContext when I finish implementing that.  As a bonus, this might open up a path for us to run these tests stand-alone in Chrome, but I don't wanna hold this up on that for now.

Comment 1

[(no longer active)]

Attachment: diff -w

This should be easier to review.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

The patch itself.

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/202d4048a8b8

Comment 4

[(no longer active)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/202d4048a8b8

Ah, wrong bug.  Too many tabs open. :(

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 747209 [details] [diff] [review]
Patch (v1)

Review of attachment 747209 [details] [diff] [review]:
-----------------------------------------------------------------

This is really nice!

r+ with or without that change.

::: content/media/webaudio/test/webaudio.js
@@ +74,5 @@
> + *                everything needed in order to set up the Web Audio graph.
> + *                In async mode, it takes a callback which should be called
> + *                with an argument set to the node to be inspected when the
> + *                callee is ready to proceed with the test.  In sync mode, it
> + *                returns the node to be inspected.

I think it would be a bit cleaner to have createGraph and createGraphAsync and call the former if it exists, otherwise the latter. Right now you're overloading createGraph with two different kinds of things.

Comment 6

[(no longer active)]

Done!

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d965d473897

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d965d473897

Comment 8

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.