870168 - mach fails to build sometimes with multiple logged-in users on os x

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[u408661]

Attachment: patch

I have a computer at home that I share with my wife. Today, I went to build m-c using mach, and got the error below. This appears to be caused because both my wife and I were logged in (via the switch user capability), and her finder had a lower PID than my finder. I've attached a patch that makes sure the finder we look for is owned by the user running mach. Will post try results when I've pushed to try.


> mach build
Error running mach:

    ['build']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AccessDenied: (pid=1252, name='Finder')

  File "/Users/hurley/src/m-c/python/mozbuild/mozbuild/mach_commands.py", line 80, in build
    finder_start_cpu = self._get_finder_cpu_usage()
  File "/Users/hurley/src/m-c/python/mozbuild/mozbuild/mach_commands.py", line 168, in _get_finder_cpu_usage
    return proc.get_cpu_times()
  File "/Users/hurley/src/m-c/python/psutil/psutil/__init__.py", line 526, in get_cpu_times
    return self._platform_impl.get_cpu_times()
  File "/Users/hurley/src/m-c/python/psutil/psutil/_psosx.py", line 122, in wrapper
    raise AccessDenied(self.pid, self._process_name)

Comment 1

[u408661]

Try results will appear at http://tbpl.mozilla.org/?tree=Try&rev=4564e80909a2

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 747205 [details] [diff] [review]
patch

Review of attachment 747205 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 4

[Gregory Szorc [:gps]]

This code doesn't run as part of the build. Please cancel your try push and save builder resources.

Comment 5

[u408661]

Done. Presumably I should mark the commit NPOTB, then?

Comment 6

[Gregory Szorc [:gps]]

Yup. "DONTBUILD (NPOTB)"

Comment 7

[u408661]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56425c094759

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56425c094759