Closed Bug 870218 Opened 6 years ago Closed 6 years ago

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtWriteFile from ntdll.dll

Categories

(Toolkit :: General, defect)

x86_64
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

On Win8 x64,

0:000> u ntdll!NtWriteFile
ntdll!NtWriteFile:
000007f8`a7da2c60 4c8bd1          mov     r10,rcx
000007f8`a7da2c63 b806000000      mov     eax,6
000007f8`a7da2c68 0f05            syscall
000007f8`a7da2c6a c3              ret
000007f8`a7da2c6b 0f1f440000      nop     dword ptr [rax+rax]

I have to analyze mov eax,6 and syscall...
Also, on win8, injecting TrackPopupMenu is also failed. (win7 works fine)

0:000> u USER32!TrackPopupMenu
USER32!TrackPopupMenu:
000007f8`a558a0c0 4883ec38        sub     rsp,38h
000007f8`a558a0c4 488b442468      mov     rax,qword ptr [rsp+68h]
000007f8`a558a0c9 48c744242800000000 mov   qword ptr [rsp+28h],0
000007f8`a558a0d2 4889442420      mov     qword ptr [rsp+20h],rax
000007f8`a558a0d7 e8242c0000      call    USER32!NtUserTrackPopupMenuEx (000007f
8`a558cd00)
000007f8`a558a0dc 4883c438        add     rsp,38h
000007f8`a558a0e0 c3              ret
As mentioned in bug 853128 comment 22:

By the way, if we could at the same time the test is failing dump the first x
bytes of the function, that would avoid having to look them up manually each
time there's a new failure. x=16 should be enough for both x86 and x86-64.
Blocks: 880004
Attached patch fix v1Splinter Review
Attachment #759003 - Flags: review?(ehsan)
Attachment #759003 - Flags: review?(ehsan) → review+
I took the liberty of pushing this patch, hope that's OK Makoto :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/d724f48ff76c
https://hg.mozilla.org/mozilla-central/rev/d724f48ff76c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.