853128 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[SpeciesX]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20890142&tree=Firefox

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll
e:\builds\moz2_slave\m-cen-w64-pgo-0000000000000000\build\obj-firefox\toolkit\xre\test\win\Makefile:41:0: command '../../../../dist/bin/TestDllInterceptor.exe' failed, return code 1
e:\builds\moz2_slave\m-cen-w64-pgo-0000000000000000\build\config\rules.mk:1781:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w64-pgo-0000000000000000/build/build/pymake/pymake/../make.py -C win check' failed, return code 2
e:\builds\moz2_slave\m-cen-w64-pgo-0000000000000000\build\config\rules.mk:1781:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w64-pgo-0000000000000000/build/build/pymake/pymake/../make.py -C test check' failed, return code 2
e:\builds\moz2_slave\m-cen-w64-pgo-0000000000000000\build\config\rules.mk:1781:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w64-pgo-0000000000000000/build/build/pymake/pymake/../make.py -C xre check' failed, return code 2
e:\builds\moz2_slave\m-cen-w64-pgo-0000000000000000\build\config\rules.mk:1781:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w64-pgo-0000000000000000/build/build/pymake/pymake/../make.py -C toolkit check' failed, return code 2

Comment 1

[Makoto Kato [:m_kato]]

not need NtFlushbufferFile hook.  But we keep this (see bug 850957).

Comment 2

[Legacy TBPL/Treeherder Robot]

Optimizer
https://tbpl.mozilla.org/php/getParsedLog.php?id=21822641&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-15 09:14:20
slave: w64-ix-slave61

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 3

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=21873396&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-16 09:55:20
slave: w64-ix-slave40

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 4

[Legacy TBPL/Treeherder Robot]

jonco
https://tbpl.mozilla.org/php/getParsedLog.php?id=21952855&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-18 02:16:08
slave: w64-ix-slave37

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 5

[Legacy TBPL/Treeherder Robot]

jonco
https://tbpl.mozilla.org/php/getParsedLog.php?id=21969180&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-18 08:32:20
slave: w64-ix-slave52

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 6

[Legacy TBPL/Treeherder Robot]

jonco
https://tbpl.mozilla.org/php/getParsedLog.php?id=22017866&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-19 06:23:20
slave: w64-ix-slave37

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 7

[Makoto Kato [:m_kato]]

Attachment: turn off injecting test of NtFlushBuffersFile on x64

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 740145 [details] [diff] [review]
turn off injecting test of NtFlushBuffersFile on x64

oops.  other patch is merged

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Turn off injecting test of NtFlushBuffersFile on x64

Comment 10

[Mike Hommey [:glandium]]

Considering bug 848020 removed the hooking of that function, you can just remove the test completely.

Comment 11

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #10)
> Considering bug 848020 removed the hooking of that function, you can just
> remove the test completely.

Ehsan says, "I'd rather us keep this test" at bug 850957 comment #2.

Comment 12

[Mike Hommey [:glandium]]

(In reply to Makoto Kato from comment #11)
> (In reply to Mike Hommey [:glandium] from comment #10)
> > Considering bug 848020 removed the hooking of that function, you can just
> > remove the test completely.
> 
> Ehsan says, "I'd rather us keep this test" at bug 850957 comment #2.

But the function is not hooked anymore. https://hg.mozilla.org/mozilla-central/rev/fe8a8cad48a4

Comment 13

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #12)
> (In reply to Makoto Kato from comment #11)
> > (In reply to Mike Hommey [:glandium] from comment #10)
> > > Considering bug 848020 removed the hooking of that function, you can just
> > > remove the test completely.
> > 
> > Ehsan says, "I'd rather us keep this test" at bug 850957 comment #2.
> 
> But the function is not hooked anymore.
> https://hg.mozilla.org/mozilla-central/rev/fe8a8cad48a4

So I make a proposal removing it by first patch of bug 850957, but ehsan wants to keep this. (bug 850957 comment #2) by code review.  First patch of bug 850957 was just remove this API hook test.

Comment 14

[Legacy TBPL/Treeherder Robot]

jonco
https://tbpl.mozilla.org/php/getParsedLog.php?id=22052919&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-20 05:22:20
slave: w64-ix-slave33

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 15

[Legacy TBPL/Treeherder Robot]

jonco
https://tbpl.mozilla.org/php/getParsedLog.php?id=22153673&tree=Try
WINNT 6.1 x86-64 try build on 2013-04-23 10:44:03
slave: w64-ix-slave58

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtFlushBuffersFile from ntdll.dll

Comment 16

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #12)
> (In reply to Makoto Kato from comment #11)
> > (In reply to Mike Hommey [:glandium] from comment #10)
> > > Considering bug 848020 removed the hooking of that function, you can just
> > > remove the test completely.
> > 
> > Ehsan says, "I'd rather us keep this test" at bug 850957 comment #2.
> 
> But the function is not hooked anymore.
> https://hg.mozilla.org/mozilla-central/rev/fe8a8cad48a4

That doesn't matter, this test is testing hooking up functions with those specific opcodes at the beginning, which is something that we want to keep working in case someone needs to hook such a function in the future.

Comment 17

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c11cfae5a69

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c11cfae5a69

Comment 19

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

"Failed to hook NtWriteFile from ntdll.dll" is also showing up; should we just disable this one as well?  We do seem to hook it in PoisonWrite(), so maybe it needs to be fixed?

Comment 20

[(no longer active)]

(In reply to comment #19)
> "Failed to hook NtWriteFile from ntdll.dll" is also showing up; should we just
> disable this one as well?  We do seem to hook it in PoisonWrite(), so maybe it
> needs to be fixed?

Can you please file a follow-up about that?  This could be bad.

Comment 21

[Makoto Kato [:m_kato]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #20)
> (In reply to comment #19)
> > "Failed to hook NtWriteFile from ntdll.dll" is also showing up; should we just
> > disable this one as well?  We do seem to hook it in PoisonWrite(), so maybe it
> > needs to be fixed?
> 
> Can you please file a follow-up about that?  This could be bad.

Ah, we need alalyze more mov opcode and syscall.  64bit implementation of NtWriteFile simply call to system call of kernel.

Comment 22

[Mike Hommey [:glandium]]

By the way, if we could at the same time the test is failing dump the first x bytes of the function, that would avoid having to look them up manually each time there's a new failure. x=16 should be enough for both x86 and x86-64.

Comment 23

[Makoto Kato [:m_kato]]

filed bug 870218.

Comment 24

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=22744452&tree=Try
WINNT 6.1 x86-64 try build on 2013-05-08 11:15:37
slave: w64-ix-slave53

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtWriteFile from ntdll.dll

Comment 25

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=22770885&tree=Try
WINNT 6.1 x86-64 try build on 2013-05-09 03:13:06
slave: w64-ix-slave46

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtWriteFile from ntdll.dll

Comment 26

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=23270612&tree=Try
WINNT 6.1 x86-64 try build on 2013-05-22 08:47:06
slave: w64-ix-slave62

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtWriteFile from ntdll.dll

Comment 27

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=23278959&tree=Try
WINNT 6.1 x86-64 try build on 2013-05-22 11:09:37
slave: w64-ix-slave60

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook NtWriteFile from ntdll.dll