870359 - (Follow-up) Add object store to RecentsDBManager database to host groups of calls

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Follow up of bug 847404. 

We need to fix what was reported in Bug 854869 and add some modifications agreed during Madrid work week (like morphing the primary key of the groups object store from string to array).

We will not be adding the contacts information yet. That will be tracked by bug 862385.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9643

Pointer to Github pull-request

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocks a blocker.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 747420 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9643

Main issues:
- the binding issue in the upgrade code (!)
- the failing tests (looks like fixing the upgrade helps ;))
- |recents_db.js| is individually loaded, so we have no guarantee than |utils.js| (lazy loaded by |recents.js|) will be there. We need to do without the dependency or load it properly.
- structured groupId stored in an array

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 747420 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9643

Etienne, I've just updated the PR to address your review comments. 

We expose now objects of this kind:

{ id: <String>,
  date: <Date>,
  number: <String>,
  type: <String>,
  status: <String>,
  lastEntryDate: <Date>,
  retryCount: <Number> }

so consumers (basically... the calllog UI) doesn't need to deal with the array-as-id.

I've also decided not to load Utils just for that simple function.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 747420 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9643

Awesome, r=me with the typo in the tests fixed + the nits

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Thanks Etienne!

https://github.com/mozilla-b2g/gaia/commit/3479338df4aa24ff99df753d9fb88807c85f2589

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3479338df4aa24ff99df753d9fb88807c85f2589 to:
v1-train: 45f1d601a9f8925cf054d6b18bbb60811057de9d