870419 - [Homescreen][User Story] when offline, need to know which apps can be used (initial scenarios)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Noemí Freire (:noemi)]

As a mobile user, when offline, I want to know which apps can be used in home screen (initial scenarios) 

Acceptance Criteria: 
*Packaged apps can be used offline as they are installed in the device
*Hosted apps with app cache defined on their manifest should be available offline
*Hosted apps without app cache defined on their manifest not being executed yet, we do not know if they can be used offline or not
*Hosted apps without app cache defined on their manifest already executed, if it does not include a manifest in the HTML it cannot be used offline

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 10033

Comment 2

[Cristian Rodriguez (:crdlc)]

The review is done, go to Github because there are some comments and improvements. Thanks a lot and great work!. After landing this patch into master, I am going to implement some unit tests in a different pull request in order to avoid conflicts if finally it goes to v1-train.

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 754703 [details]
Pointer to PR 10033

Great job Fran!! Thanks a lot

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Thanks a lot for the review Cristian, was more than helpful, great job as always.

PR landed:

https://github.com/mozilla-b2g/gaia/commit/2c59aa2b4027d691394bd9914ce31526e754e821

Comment 5

[Cristian Rodriguez (:crdlc)]

Filled bug 877075 to add unit tests

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 754703 [details]
Pointer to PR 10033

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: Bad user experience when user is offline 
Testing completed: yes, 2 weeks on master no issues found
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch:


Hi Patrick, I know you are still discussing with Rafa the final approach (allowing click or not), but that's a minor modification for this patch, so I'm asking for gaia approval to include this in v1-train.

Thanks!
F.

Comment 7

[Jason Smith [:jsmith]]

Isn't it a bit too late to be taking new features into 1.1?

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Jason Smith [:jsmith] from comment #7)
> Isn't it a bit too late to be taking new features into 1.1?

yup, but this was requested by product people, so making it formal and following the process :)

Thanks Jason!

Comment 9

[Alex Keybl [:akeybl]]

pdol - can you confirm that this is a 1.1 requested feature? Looks OK for 1.2 to me.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Alex Keybl [:akeybl] from comment #9)
> pdol - can you confirm that this is a 1.1 requested feature? Looks OK for
> 1.2 to me.

I just forwarded you the email that talked about this with product. The original conclusion was that this is a 1.2 feature and out of scope for 1.1.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

by emails involving Jonas, Patrick and Rafa, my conclusions were this (and just this specific thing regarding the offline improvements) will be taking into 1.1

If that's not the case will ask again Rafa to clarify this point.

Thanks a lot guys!
F.