If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Homescreen] Back out greyed out icons when offline

VERIFIED FIXED

Status

Firefox OS
Gaia::Homescreen
--
blocker
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jachen, Assigned: crdlc)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
We agreed with TEF to back this out: https://bugzilla.mozilla.org/show_bug.cgi?id=870419 and work together on other offline solutions.

Please let me know any questions.
(Reporter)

Updated

4 years ago
blocking-b2g: --- → koi?
Depends on: 870419
(Assignee)

Comment 1

4 years ago
Sorry, what do you mean?, back out all the code or remove the SVG filter that implements the grayscale?

Updated

4 years ago
blocking-b2g: koi? → koi+
Jaime is referring to the actual greying out of icons as well as the prevention of the user from launching a greyed out app.  This would be for both koi and master.
Assignee: nobody → francisco.jordano
Whiteboard: [systemsfe]
Francisco, are you working on this?
Flags: needinfo?(francisco.jordano)
No, I'm not currently working on that part, we already finished the work as Christian commented.
Flags: needinfo?(francisco.jordano)

Comment 5

4 years ago
So the actual graying out of icons has been backed out, per comment #4? Should this bug be marked RESOLVED FIXED?
(In reply to Stephany Wilkes from comment #5)
> So the actual graying out of icons has been backed out, per comment #4?
> Should this bug be marked RESOLVED FIXED?

Not to my understanding. The bug in question is still closed, which makes it looks this is still present in the build.

Comment 7

4 years ago
Francisco, this bug is assigned to you. Does your comment #4 mean that you are not doing the backing out work? If so, to whom can we assign this bug instead?
(Assignee)

Updated

4 years ago
Assignee: francisco.jordano → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 8

4 years ago
Created attachment 824547 [details]
Patch v1
Attachment #824547 - Flags: review?(francisco.jordano)
Comment on attachment 824547 [details]
Patch v1

Love it, simple and working perfectly, not falling into possible regressions.

Patch that just removes css is a win!!
Attachment #824547 - Flags: review?(francisco.jordano) → review+
Landed:


https://github.com/mozilla-b2g/gaia/commit/80bb1a9bfaddf48ed4e259d406fa89f2d5f68286
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Keywords: verifyme
(Assignee)

Updated

4 years ago
Blocks: 924942
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 80bb1a9bfaddf48ed4e259d406fa89f2d5f68286
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(crdlc)
Verified Fixed: Was able to verify that icons are no longer grayed out when offline.

Environmental Variables
Device: Buri v1.3 Moz RIL
Build ID: 20131111040200
Gecko: http://hg.mozilla.org/mozilla-central/rev/bc8c1eb0f2ba
Gaia: bcb4f94524ef02e9ef16b604d16c39e5a9c41281
Platform Version: 28.0a1
RIL Version: 01.02.00.019.102 
Firmware Version: US_20131104
Status: RESOLVED → VERIFIED
Keywords: verifyme
(Assignee)

Comment 13

4 years ago
Merged in v1.2

https://github.com/mozilla-b2g/gaia/commit/9969e2c8b0f3398220330f31449152f346d0c0a8
Flags: needinfo?(crdlc)
(Assignee)

Updated

4 years ago
status-b2g-v1.2: --- → fixed
You need to log in before you can comment on or make changes to this bug.