927599 - [Homescreen] Back out greyed out icons when offline

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[jachen]

We agreed with TEF to back this out: https://bugzilla.mozilla.org/show_bug.cgi?id=870419 and work together on other offline solutions.

Please let me know any questions.

Comment 1

[Cristian Rodriguez (:crdlc)]

Sorry, what do you mean?, back out all the code or remove the SVG filter that implements the grayscale?

Comment 2

[Peter Dolanjski [:pdol]]

Jaime is referring to the actual greying out of icons as well as the prevention of the user from launching a greyed out app.  This would be for both koi and master.

Comment 3

[Gregor Wagner [:gwagner]]

Francisco, are you working on this?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

No, I'm not currently working on that part, we already finished the work as Christian commented.

Comment 5

[Stephany Wilkes]

So the actual graying out of icons has been backed out, per comment #4? Should this bug be marked RESOLVED FIXED?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Stephany Wilkes from comment #5)
> So the actual graying out of icons has been backed out, per comment #4?
> Should this bug be marked RESOLVED FIXED?

Not to my understanding. The bug in question is still closed, which makes it looks this is still present in the build.

Comment 7

[Stephany Wilkes]

Francisco, this bug is assigned to you. Does your comment #4 mean that you are not doing the backing out work? If so, to whom can we assign this bug instead?

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 824547 [details]
Patch v1

Love it, simple and working perfectly, not falling into possible regressions.

Patch that just removes css is a win!!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Landed:


https://github.com/mozilla-b2g/gaia/commit/80bb1a9bfaddf48ed4e259d406fa89f2d5f68286

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 80bb1a9bfaddf48ed4e259d406fa89f2d5f68286
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 12

[Peter Bylenga [:PBylenga]]

Verified Fixed: Was able to verify that icons are no longer grayed out when offline.

Environmental Variables
Device: Buri v1.3 Moz RIL
Build ID: 20131111040200
Gecko: http://hg.mozilla.org/mozilla-central/rev/bc8c1eb0f2ba
Gaia: bcb4f94524ef02e9ef16b604d16c39e5a9c41281
Platform Version: 28.0a1
RIL Version: 01.02.00.019.102 
Firmware Version: US_20131104

Comment 13

[Cristian Rodriguez (:crdlc)]

Merged in v1.2

https://github.com/mozilla-b2g/gaia/commit/9969e2c8b0f3398220330f31449152f346d0c0a8