870576 - SecReview: Add --marionette CLI to enable Marionette on all Firefox builds

Status: RESOLVED FIXED

(mozilla.org :: Security Assurance: Review Request, task)

Description

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

copied from https://bugzilla.mozilla.org/show_bug.cgi?id=870445#c8
---//---

* Who is/are the point of contact(s) for this review? David Burns :AutomatedTester

* Please provide a short description of the feature / application (e.g. problem solved, use cases, etc.): 

Marionette allows remote execution of tasks in the browser that allow end users to be able to test web applications. This is a port of FirefoxDriver from the Selenium[1] project with a number of added pieces to fit in with Mozilla's needs as well. Currently used on FirefoxOS automation and is now required for SocialAPI testing as in comment 0
Marionette is based on the W3C WebDriver specification[2] currently being drafted and implemented by numerous vendors.

* Please provide links to additional information (e.g. feature  page, wiki) if available and not yet included in feature description: 

https://developer.mozilla.org/en-US/docs/Marionette/Marionette

* Does this request block another bug? If so, please indicate the bug number 
 
* This review will be scheduled amongst other requested reviews. What is the urgency or needed completion date of this review? 

dmose's team needs this landed ASAP so they can write tests for Talkilla, which is scheduled to be released late June.  Without this, they'd have to use a hacked up webdriver solution instead, which is probably less ideal, and may require extra work later to port to Marionette.

* To help prioritize this work request, does this project support  a goal specifically listed on this quarter's goal list?  If so, which  goal? 

Yes, this is needed to support the SocialAPI/Talkilla goals for this quarter

*Please answer the following few questions: (Note: If you are asked to describe anything, 1-2 sentences shall suffice.) 

    Does this feature or code change affect Firefox, Thunderbird or any product or service the Mozilla ships to end users? 

    Yes

    Are there any portions of the project that interact with 3rd party services? 

    No

    Will your application/service collect user data? If so, please describe 

    No

*If you feel something is missing here or you would like to  provide other kind of feedback, feel free to do so here (no limits on  size): 

Chromium already ships[3] with their implementation of the spec and uses similar technique as discussed above of CLI flags and no prefs.
Opera also has their implementation[4], again using the technique described earlier of CLI flags and no prefs as standard

* Desired Date of review (if known from https://mail.mozilla.com/home/[e-mail]/Security%20Review.html) and whom to invite. 

May 13, please invite dmose, dburns, jgriffin, mdas

[1] http://selenium.googlecode.com/
[2] http://dvcs.w3.org/hg/webdriver/raw-file/tip/webdriver-spec.html
[3] http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/webdriver/
[4] https://github.com/operasoftware/operadriver

Comment 1

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

https://wiki.mozilla.org/Security/Reviews/MarionetteCLIAll