Closed
Bug 870579
Opened 12 years ago
Closed 12 years ago
IID bump for nsIWebSocketChannel
Categories
(Core :: Networking: WebSockets, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: akeybl, Assigned: jduell.mcbugs)
References
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
jduell.mcbugs
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Forgot to rev the IID for nsIWebSocketChannel in bug 849364. Let's do that now, unless there's no chance for binary add-on or web compatibility impact.
+++ This bug was initially created as a clone of Bug #849364 +++
websocket pings are turned off by default (we were worried they consume too much power--ie. wake up the phone and/or radio when it would otherwise be asleep. It's not actually clear if that's the case on android or B2G). But in any case bug 763198 is simplified by turning keepalive on for its websocket connection, so this will provide a way to do that per-websocket.
|
Assignee | |
Comment 1•12 years ago
|
||
I'll land this whenever inbound opens up again, just 'cause it's the right thing to do, but there's actually no chance of any compat hit. The IDL we changed is used only internally, and I'd be really surprised if any C++ code uses it (and JS won't be affected since it only added new fields).
Attachment #747662 -
Flags: review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 747662 [details] [diff] [review]
v1
pre-approving for Aurora 22 as well
Attachment #747662 -
Flags: approval-mozilla-aurora+
|
|
Assignee | |
Comment 5•12 years ago
|
||
status-firefox22:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•