Update mozmill tests after BookmarksMenuButton renamed to BookmarkingUI

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: AndreeaMatei)

Tracking

unspecified

Firefox Tracking Flags

(firefox22 unaffected, firefox23 fixed)

Details

(Whiteboard: [lib])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When bug 867343 lands (about to land on inbound), I imagine something siilar to bug 865211 will rear its head. A simple renaming is required - s/BookmarksMenuButton/BookmarkingUI/.
We have to get this change in today to not cause massive failures over the weekend. Thanks for the heads-up Mike.
Priority: -- → P1
Whiteboard: [mozmill-endurance] → [lib]
(Assignee)

Comment 2

6 years ago
Created attachment 748034 [details] [diff] [review]
patch v1

Updated places.js and toolbars.js libraries, the  button has 'star-button' as id now. I've left the variable's name bookmarksButton as it is more suggestive in our context.
Tested with: ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux/1368199246/
Assignee: nobody → andreea.matei
Status: NEW → ASSIGNED
Attachment #748034 - Flags: review?(hskupin)
(Assignee)

Updated

6 years ago
status-firefox23: --- → affected
Comment on attachment 748034 [details] [diff] [review]
patch v1

Review of attachment 748034 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Lets get this landed when the implementation bug gets merged to mozilla-central.
Attachment #748034 - Flags: review?(hskupin) → review+
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/bf1a392db4c5

Thank you for the quick fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox22: --- → unaffected
status-firefox23: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.