870810 - Update mozmill tests after BookmarksMenuButton renamed to BookmarkingUI

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

When bug 867343 lands (about to land on inbound), I imagine something siilar to bug 865211 will rear its head. A simple renaming is required - s/BookmarksMenuButton/BookmarkingUI/.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have to get this change in today to not cause massive failures over the weekend. Thanks for the heads-up Mike.

Comment 2

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Updated places.js and toolbars.js libraries, the  button has 'star-button' as id now. I've left the variable's name bookmarksButton as it is more suggestive in our context.
Tested with: ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux/1368199246/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 748034 [details] [diff] [review]
patch v1

Review of attachment 748034 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Lets get this landed when the implementation bug gets merged to mozilla-central.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/bf1a392db4c5

Thank you for the quick fix.