870920 - Cannot install packaged apps on 1.1 and trunk

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[andre]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130508 Firefox/23.0
Build ID: 20130508031113

Steps to reproduce:

We've build B2G from source using the instructions on MDN. The build and reflash worked fine but now we can't install packaged apps. Both the "kitchensink" and "memos" app fail to install.

The phones affected are all Geeksphone Keons. There are multiple people affected. All that built from source.


Actual results:

All packaged apps fail to install showing "download has stopped" and on logcat we have the following error:

E/GeckoConsole(  107): Content JS INFO at app://system.gaiamobile.org/js/app_install_manager.js:197 in ai_handleDownloadError: downloadError event, error code is INVALID_IDS_JSON

The packaged apps work well when pushed to the device using the simulator


Expected results:

the apps should have installed correctly.

Comment 1

[Jason Smith [:jsmith]]

1.1 smoketest regression. Needs to block.

Comment 2

[Jason Smith [:jsmith]]

FWIW, I reproduced this also on 5/10 1.1 unagi build.

Comment 3

[Jason Smith [:jsmith]]

Fabrice thinks bug 814136 broke this.

Comment 4

[Jason Smith [:jsmith]]

Antonio - Any ideas?

Comment 5

[Jason Smith [:jsmith]]

Here's what I'm getting on my logcat on unagi 1.1:

05-10 11:31:08.777: E/GeckoConsole(109): Content JS INFO at app://system.gaiamobile.org/js/app_install_manager.js:197 in ai_handleDownloadError: downloadError event, error code is MISSING_IDS_JSON

Comment 6

[Aaron Train [:aaronmt]]

Unable to reproduce on Android (Nightly 05/10) seems unaffected.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Aaron Train [:aaronmt] from comment #6)
> Unable to reproduce on Android (Nightly 05/10) seems unaffected.

Hmm...that's probably because FxAndroid doesn't have privileged app support yet. The regressing bug only affects privileged apps.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #7)
> (In reply to Aaron Train [:aaronmt] from comment #6)
> > Unable to reproduce on Android (Nightly 05/10) seems unaffected.
> 
> Hmm...that's probably because FxAndroid doesn't have privileged app support
> yet. The regressing bug only affects privileged apps.

Meant to say - signed apps from marketplace.

Comment 9

[Antonio Manuel Amaya Calvo (:amac)]

This is related with bug 816136. As I said in comment 56 on that bug [1], after that landed the signed apps *require* having an ids.json as part of the signed package. The /security/manager/ssl/tests/unit/test_signed_apps/sign_b2g_app.py script on that bug adds that file when signing a package. Signed packages that don't include that file won't be installed. 

According to bug 852720, comment 65, though, I thought that packaged apps from the Marketplace already included that information [2].

I'm making a new build for unagi and will check with our own packaged apps.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=814136#c56
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=852720#c65

Comment 10

[Antonio Manuel Amaya Calvo (:amac)]

Ok, I did try with a new build (from May 8th, I'm compiling a new one right now just in case but I checked that this build included the ids changes) and with our own signed packages (from our dogfooding store) and it works correctly.

Can you point me to a package that's failing?

Comment 11

[Jason Smith [:jsmith]]

(In reply to Antonio Manuel Amaya Calvo from comment #10)
> Ok, I did try with a new build (from May 8th, I'm compiling a new one right
> now just in case but I checked that this build included the ids changes) and
> with our own signed packages (from our dogfooding store) and it works
> correctly.
> 
> Can you point me to a package that's failing?

https://marketplace.firefox.com/app/poppit was failing for me on today's build.

Comment 12

[andre]

The kitchensink package and the memos app are both failing.

memos is at https://marketplace.firefox.com/app/memos/
kitchensink is at https://marketplace.firefox.com/app/kitchensink/

both work when pushed to the device using the simulator

Comment 13

[Jason Smith [:jsmith]]

FYI - Rob just confirmed Poppit is does not have ids.json in the package.

Comment 14

[Jason Smith [:jsmith]]

Update in IRC:

* Poppit - No ids.json
* Memos - Has an ids.json
* Kitchen Sink - Has an ids.json

Comment 15

[Antonio Manuel Amaya Calvo (:amac)]

The ids.json on the marketplace have the fields: 

"app_id" and "version_id": 1446546

While Webapps.jsm actually expects the fields: 

"id", "version"

which are the ones that the test app actually includes, too.

I think we had a small miscommunication there. I can create a new patch here changing the signing script and the Webapps.jsm verifying code to check for the new fields, or you can change the way the zips are being signed to include the fields that are being actually checked.

Let me know what you prefer.

Comment 16

[andre]

The error I experienced is INVALID_IDS_JSON and not MISSING_IDS_JSON, so even if the ids.json is present, there is something wrong. Can you install packaged apps from the marketplace if you build from source?

Comment 18

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Antonio Manuel Amaya Calvo from comment #15)
> The ids.json on the marketplace have the fields: 
> 
> "app_id" and "version_id": 1446546
> 
> While Webapps.jsm actually expects the fields: 
> 
> "id", "version"
> 
> which are the ones that the test app actually includes, too.

I think Webapps.jsm and the test app are correct.

Comment 19

[Jason Smith [:jsmith]]

Okay. That officially now makes this a marketplace bug.

Comment 20

[Jason Smith [:jsmith]]

Rob - Can you look into this?

Comment 21

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/49437a2

Comment 22

[andre]

Hi Guys,

I am the one who originally posted the bug. I am still receiving the same error. I've built and flashed v1-train on two Keons right now and I can't install packaged apps. I receive the following information on logcat:

E/GeckoConsole(  107): Content JS INFO at app://system.gaiamobile.org/js/app_install_manager.js:197 in ai_handleDownloadError: downloadError event, error code is INVALID_IDS_JSON

This happens with all package apps I try.

Comment 23

[Jason Smith [:jsmith]]

I'm guessing the fix hasn't been pushed yet.

Comment 24

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #23)
> I'm guessing the fix hasn't been pushed yet.

Pushed to production, I mean.

Comment 25

[andre]

Oh, I see. I am new to bug reporting, sorry for reopening it.

Comment 26

[Antonio Manuel Amaya Calvo (:amac)]

(In reply to andre from comment #25)
> Oh, I see. I am new to bug reporting, sorry for reopening it.
You don't need to rebuild B2G to get the fix, btw, since the fix is on the marketplace, not on the code that runs on the device. Once the marketplace get the new code, you'll be able to install your apps again.

Comment 27

[Wil Clouser [:clouserw]]

Push date is in the target milestone, fwiw. Live next Thursday.

Comment 29

[Chris Kreinbring [:CKreinbring]]

Repros on Inari 1.1 commercial RIL and on Unagi master build.

Inari details:
Build ID: 20130516070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4b5fe47ad76c
Gaia: 08074c417f9e095168f38a449dabe0e2325b7353
Version #: 18.0

Comment 30

[Chris Lord [:cwiiis]]

(In reply to Wil Clouser [:clouserw] from comment #27)
> Push date is in the target milestone, fwiw. Live next Thursday.

Next Thursday as in the 23rd, or yesterday? This issue still exists at the moment, should this bug really be marked as fixed yet? This seems similar to inbound/central for normal Gecko work, where a bug isn't marked as fixed until it hits central.

Comment 31

[Julien Wajsberg [:julienw]]

I can access the new marketplace (which I like a lot btw :) ), but I still have the same issue (tested with the "Distant Orbit" app).

Comment 32

[Jason Smith [:jsmith]]

Rob - Any ideas why?

Comment 33

[Rob Hudson [:robhudson]]

(In reply to Chris Lord [:cwiiis] from comment #30)
> Next Thursday as in the 23rd, or yesterday?

It was yesterday, yes.

I'm realizing now, however, what the problem is.

The ids.json file is added upon package submission. So me fixing the code to change the JSON key names to match what device side expects will only apply to newly uploaded packages. All existing packages will still have the old ids.json files, and thus, fail installation.

Can we confirm that for a newly uploaded package that this works? If so, we can think about how to fix old packages.

Comment 34

[Jason Smith [:jsmith]]

Discussed in IRC, but Rob & I confirmed this issue we are seeing here is happening with the old packages, not the new ones.

Comment 35

[Rob Hudson [:robhudson]]

I filed bug 873600 to fix pre-existing packages.