871035 - Marketplace package fails on update

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

1. Flash your phone.
2. Marketplace update becomes available. Download the update:
http://f.cl.ly/items/2E2e2T2L3t370v3X1m2m/2013-05-10-15-03-52.png
3. After a few seconds an error message appears:
http://f.cl.ly/items/3i0r2l41352l0J0U472T/2013-05-10-15-04-30.png

FWIW, on my phone `/data/local/webapps/webapps.json` contains the following:

...
  "marketplace.firefox.com": {
    "origin": "app://marketplace.firefox.com",
    "installOrigin": "https://marketplace.firefox.com",
    "receipt": null,
    "installTime": 132333986000,
    "manifestURL": "https://marketplace.firefox.com/packaged.webapp",
    "removable": false,
    "localId": 1037,
    "etag": "\"6f996751558be05eaa8bec8db03edbe0\"",
    "packageEtag": "\"9be1d52a14b87fdf18ab00b4cdebdedc\"",
    "appStatus": 1,
    "basePath": "/data/local/webapps",
    "id": "marketplace.firefox.com",
    "installState": "installed",
    "name": "Marketplace",
    "csp": "",
    "lastCheckedUpdate": 1368223429858,
    "downloadAvailable": false,
    "downloadSize": 10174,
    "retryingDownload": false,
    "downloading": false,
    "progress": 10174
  },
...

As the update failed, the ETags remain unchanged: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace.firefox.com/metadata.json

If you look at https://marketplace.firefox.com/packaged.webapp you'll see that a new version (0.0.2) is and the ETags have changed.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

I'm not sure if this is pertinent but I see this in my logs:

E/GeckoConsole(  109): Content JS INFO at app://system.gaiamobile.org/js/updatable.js:103 in anonymous: downloadError event, error code is MISSING_IDS_JSON

Comment 2

[Wil Clouser [:clouserw]]

Dupe of Bug 870920?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> Dupe of Bug 870920?

Yes.

Comment 4

[Rob Hudson [:robhudson]]

Is it a dupe? I thought 870920 was about INVALID_IDS_JSON, whereas this is MISSING_IDS_JSON.

The invalid ids is b/c we have a name mismatch. Missing is different -- the file isn't there at all.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #4)
> Is it a dupe? I thought 870920 was about INVALID_IDS_JSON, whereas this is
> MISSING_IDS_JSON.
> 
> The invalid ids is b/c we have a name mismatch. Missing is different -- the
> file isn't there at all.

Yeah the original comment was - but Jason said he saw INVALID_IDS_JSON in bug 870920 comment 5.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #5)
> (In reply to Rob Hudson [:robhudson] from comment #4)
> > Is it a dupe? I thought 870920 was about INVALID_IDS_JSON, whereas this is
> > MISSING_IDS_JSON.
> > 
> > The invalid ids is b/c we have a name mismatch. Missing is different -- the
> > file isn't there at all.
> 
> Yeah the original comment was - but Jason said he saw INVALID_IDS_JSON in
> bug 870920 comment 5.

It could be possible that these are separate bugs on the marketplace side. When I originally duped the bug, I assumed that they were the same client-side issue. Should we reopen and track this as a separate marketplace bug?

Comment 7

[Rob Hudson [:robhudson]]

The marketplace packaged app isn't uploaded to the marketplace so it doesn't actually get the META-INF/ids.json file like other packaged apps do.

Since we maintain the packaged app and sign it outside of the devhub/reviewer flow we can probably add a static ids.json file to fix this. We'd need to bump the version each time we publish however.

Different bugs definitely.

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/fireplace/commit/c92b2bb0