871127 - [dialer] cannot make a second call through dialer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[leo.bugzilla.gecko]

Currently, we can only make a second call through the contact app.
But for GCF requirement, we need to make a second call through the dialer.

Test procedure is following;

Test procedure 
1. Set up MO call to Client 1. 
2. Use the Dialler to make a second call to Client2. 
3. Clear the existing call on Client1. 
4. Use the Dialler to make a second call to Client1. 
5. Clear the existing call on Client2 while attempting to retrieve the call on DUT. 
6. Use the Dialler to make a second call to Client2. 
7. Clear the existing call on Client2. 
8. Retrieve Call with Client 1. 

Will mozilla support this feature?

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Please comment on the current, expected, and future feature work in this are so we can determine if this should block.

Comment 2

[Kai-Chih Hu [:khu]]

cc Joe.

Comment 3

[Anthony Ricaud (:rik)]

I'll take this as part of the conference call work in 1.2.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Making a second call isn't blocked by conference call support. Clearing the dependency!

Comment 5

[Anthony Ricaud (:rik)]

First step to complete this is to allow resizing the CallScreen attention-screen. I've talked with Vivien and we're gonna use window.resizeTo() with threshold values to switch between fullsize and statusbar size.

I'll talk with Gabriele about Gecko sending mozbrowser events when we call those so that we can react.

Comment 6

[Anthony Ricaud (:rik)]

I have a working prototype of this. We'll need to rework the dialer app to be usable with a bigger statusbar. That might be a big task, I don't know yet.

Comment 7

[Anthony Ricaud (:rik)]

I only needed a small change to adapt the app to a different height.

Two things are needed to land the first version for this:
- Visual asset for the "Add Call CTA". It's a phone handset with a + next to it. See page 15 of the Dialer Spec v0.7. Victoria, can you help with this?
- Landing the Gecko part (bug 891763) and then landing the Gaia system part (bug 908186) for resizing the attention screen.

Note that the first version will behave weirdly because we'll need to fix app transitions with an attention screen (bug 908258).

Comment 8

[Anthony Ricaud (:rik)]

Removing the needinfo as I got all the icons through email.

Comment 9

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11931

Pointer to Github pull-request

Comment 10

[Anthony Ricaud (:rik)]

Comment on attachment 799687 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11931

This still relies on an uncommitted patch for bug 908186.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 799687 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11931

It's hard to find anything to nit pick on..

r=me with kinder country bonus :)

Comment 12

[Anthony Ricaud (:rik)]

Landed with https://github.com/mozilla-b2g/gaia/commit/c239c1909a3aecf046d40ab81d01a4f0681784d3

Can we sign a deal with Kinder for FxOS 1.2? Free deliveries in our offices \o/

Comment 13

[Etienne Segonzac (:etienne)]

(In reply to Anthony Ricaud (:rik) from comment #12)
> Landed with
> https://github.com/mozilla-b2g/gaia/commit/
> c239c1909a3aecf046d40ab81d01a4f0681784d3
> 
> Can we sign a deal with Kinder for FxOS 1.2? Free deliveries in our offices
> \o/

Well we could at least name the 1.4 release Kinder country :)