871390 - Leaking Shmem with NoSwap canvas update

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Simple fix

This is a regression from bug 863223.

When we send the transaction, we add the Shmem to the changeset and clear our local reference to it.

On the compositor side, we give the Shmem to the ImageHost, which uploads to the texture from it and then creates a reply to send it back.

Since this is a no-reply transaction, we don't bother to send the reply and we leak instead.

What was the intended behaviour here? To create a new shmem every frame (and have the compositor free it), or to keep re-using it (and require that the compositor finish copying from it during the transaction).

We should also probably send this intention over IPC so that the compositor knows that it shouldn't be writing a reply. And assert that no reply changesets are generated.

Attached is a simple fix that just makes sure we hang onto a copy of the Shmem so we can release it.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Sends 2d transactions synchronously and webgl ones async

This bug is a regression from my patch for 863223. I accidentally made 2d canvas transaction async instead of webgl ones.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d63027c3baa8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d63027c3baa8

Comment 6

[Aaron Train [:aaronmt]]

Aurora?

Comment 7

[Scoobidiver (away)]

It makes bug 760394 spike in 23.0a2.

Comment 8

[Aaron Train [:aaronmt]]

^

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 749313 [details] [diff] [review]
Sends 2d transactions synchronously and webgl ones async

[Approval Request Comment]
Low risk, fixes gigantic memory leak when using 2d canvas. Been on m-c for a couple weeks without issues.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/579c6a2b3e2b