871472 - [Camera] unlocking the wakelock without proper testing creates problem in closing camera app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P3)

Description

[Leo]

1. Title : unlocking the wakelock without proper testing creates problem in closing camera app.
2. Precondition : camera should be working fine
3. Tester's Action : (1) launch camera from lock screen
                     (2) minimize and reopen it again.

4. Detailed Symptom (ENG.) : Wakelock created for camera preview is not properly unlocked. So, because of this if camera app is relaunched for second time from lockscreen, camera preview will not be shown because the earlier instance of camera app is not released.
5. Expected : Wakelock created for camera preview should be unlocked only when filmstrip images/videos are previewed.
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 3c48f7af4ecc8d32f62a44f0a30d4f18895bc33e
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Pointer to pull request

Hi Dale,

This is a regression for bugzilla ID: 835193, a condition was missed in 835193.
Wakelock which is created for camera preview should be unlocked only when filmstrip items preview.

This is now fixed. Please review the patch.

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 748739 [details]
Pointer to pull request

There is a nit in github to be addressed and similiarly to the last patch there is an unnecessary mode change in this commit that should be taken out, once those are fixed this is good to go.

Comment 3

[Leo]

Attachment: Pointer to pull request

Hi Dale,

I have done the changes as per your suggestions. Also, taken care for mode changes.
Please check the patch

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 749209 [details]
Pointer to pull request

Looks good, thanks

Comment 5

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/c70775cb8ed6e46fe4afb512f2c27c7d39bbf6be

Comment 6

[Dale Harvey (:daleharvey)]

Sorry, forgot to mark resolved

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Uplifted c70775cb8ed6e46fe4afb512f2c27c7d39bbf6be to:
v1-train: 945e65f04d163001c39f7ecfc37368272fc6d22e