871636 - Reopening saved draft stubbornly re-adds deleted automatic CC or BCC recipients

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

This has annoyed me many times as a violation of ux-control:
After manually deleting automatic CCs/BCCs, then saving as draft, closing, reopening - deleted CCs/BCCs stubbornly reappear. They should not.

STR

1) For YourAccount, set some automatical CCs/BCCs:
Tools > account settings > YourAccount > copies & folders > When sending messages, automatically:
[x] Cc these email addresses:  [[e-mail]    ]
[x] Bcc these email addresses: [[e-mail]   ]

2) compose new message

3) manually delete/remove automatical CC/BCC recipients
(optionally add a To-recipient: [e-mail])

4) Verify and memorize current recipients of your draft, then:
File > Save As > Draft (Ctrl+S)

5) Close draft (i.e. close composition window)

6) Verify recipients of saved draft from 3pane's msg preview

7) Reopen draft

8) Verify recipients of reopened draft and compare with step 4)

Actual Result

4) when saving draft:
depending on Step 3, there are either
- no recipients, OR
- one To-recipient: [e-mail]

6) Accordingly, saved draft preview has exactly these recipients (none or one)

7) After re-opening the draft into composition mode, auto-CCs and auto-BCCs magically re-appear, i.e. they are re-added to the composition although user has explicitly deleted them and they are not seen in the draft.

Expected result:

7) When re-opening saved draft, TB should NOT add auto-CCs and auto-BCCs again. This is unexpected and obviously violating ux-control and ux-consistency between what was saved, draft preview, and the draft after reopening. They should all be the same, and TB should not alter the message recipients at this time, which is really unsolicited.

Iow, we should only add auto-CCs and auto-BCCs
a) *once* when a new message is created (new|reply|forward etc.) OR
b) *once* when the sender of an existing composition is changed and the new sender comes with new auto-CCs/BCCs.
Otherwise, TB needs to respect the integrity of saved drafts.

Comment 1

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #0)

> 3) manually delete/remove automatical CC/BCC recipients
> (optionally add a To-recipient: [e-mail])

That is, you manually delete [e-mail] and [e-mail] *from your composition's recipient section*.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Don't do the block that sets up auto-cc, auto-bcc and fixes reply-to if it's a draft. One-liner.

Comment 3

[Mark Banner (:standard8)]

Is this a regression of one of the bugs landed in TB 24, or has it been around for a while and just not reported?

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 818632 [details] [diff] [review]
proposed fix

This seems sensible in any case. r=Standard8

Comment 5

[Magnus Melin [:mkmelin]]

AFAIK, this has been around forever.

Comment 6

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/ab678895a5a5 -> FIXED