871835 - [MMS] Re-factor attachments to work with Blob data

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Mike Pennisi [:jugglinmike]]

Currently, Attachment data is modeled as a URI string. Because of this, MMS's cannot properly transmit attachments created from Blobs. The Attachment class should be re-factored to abstract over data Blobs, and the code that interfaces with it (i.e. SMIL and Compose) should be updated to match.

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Re-factor attachments to work with Blob data

Comment 2

[Mike Pennisi [:jugglinmike]]

Attachment: Re-factor attachments to work with Blob data

Integrating gnarf's spoken feedback

Comment 3

[Mike Pennisi [:jugglinmike]]

Attachment: Re-factor attachments to work with Blob data

Adding note for future test re-structuring

Comment 4

[Corey Frang [:gnarf]]

https://github.com/mozilla-b2g/gaia/commit/5413788cbafccfad50780a9ef3685ee8efa8d3e7

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train:b1d002e

Comment 6

[Deepa Subramanian]

Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?

Comment 7

[Corey Frang [:gnarf]]

The only thing to test about this on a user side is being able to see media attachments still, it is a refactor only.