868227 - [MMS][User Story] Attachment (pre-send) options

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Dan Heberden]

User Story:
After attaching an image #840044, a video #868225, or audio file #868190 I can tap that attachment (image/video thumbnail or audio icon) to be presented with a list of options to view/listen/play that attachment, replace that attachment, or remove that attachment.

Comment 1

[ayman maat :maat]

Dan from a UX perspective 'replace that attachment' is the lowest priority of these functions. If time is tight it can be deferred.

Comment 2

[greg]

I am assuming this bug includes making the buttons function, rather than just making the menu appear. In that case, https://bugzilla.mozilla.org/show_bug.cgi?id=840047 would be a duplicate of this one. I already have the work done for the menu to appear with non-functioning buttons, so I'm going ahead and making them work now.

Comment 3

[greg]

Having trouble finding a mock / wireframe for the Preview, anyone able to point me in the right direction?

The replace feature is blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=840044

Comment 4

[Corey Frang [:gnarf]]

(In reply to greg from comment #3)
> Having trouble finding a mock / wireframe for the Preview, anyone able to
> point me in the right direction?
> 
> The replace feature is blocked by
> https://bugzilla.mozilla.org/show_bug.cgi?id=840044

Pretty sure it's just firing the open MozActivity

Comment 6

[greg]

Attachment: pull request on github

Comment 7

[greg]

Couldn't get this landed yesterday, I'm in office doing final code review changes and coordinating with :gnarf

Comment 8

[greg]

:gnarf37 reviewed and let me know this was good to go, should be landed soon. is anything needed from me?

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 750689 [details] [review]
pull request on github

r=me for hash 20e4c1be5ae09b624f0c6a0afb2f3c41eb705203

go for it, thanks for the hard work. Any more tests before landing is fine for me too.

Comment 10

[Corey Frang [:gnarf]]

master: f41344254e0ee3101480890a9f26deae083bfee7

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 66401e6

Comment 12

[Darren]

https://moztrap.mozilla.org/manage/cases/?filter-id=8435
https://moztrap.mozilla.org/manage/cases/?filter-id=8436
https://moztrap.mozilla.org/manage/cases/?filter-id=8437

Created test cases for issue, didn't see a UCID for the User story so marked the cases as "Messages-000".