872479 - Toolbox tab icons are misplaced

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Mihai Sucan [:msucan]]

I'm not sure which recent patch touched the toolbox tab icons but they started rendering wrongly on my system.

Here is a screenshot: http://img.i7m.de/show/cbtsv.png

Joe: do you know of any recent toolbox tabs-related changes?

Comment 1

[Victor Porof [:vporof][:vp]]

Maybe bug 856814?

Comment 2

[Mihai Sucan [:msucan]]

Indeed. This is a regression caused by bug 856814. Thanks for finding the bug. Will submit a patch to fix the issue.

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed fix

-moz-box-align:center was removed in bug 856814. That is needed to get correct alignment on Linux (at least).

Screenshot before this patch:
http://img.i7m.de/show/xjd5f.png

Screenshot after this patch:
http://img.i7m.de/show/5oumc.png

This patch only changes the Linux theme - as I understand the toolbar already looks fine on Windows and Macs.

This bug affects Aurora as well. I will want Aurora approval as well.

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 750381 [details] [diff] [review]
proposed fix

Review of attachment 750381 [details] [diff] [review]:
-----------------------------------------------------------------

Ok!

Comment 5

[Mihai Sucan [:msucan]]

Landed:
https://hg.mozilla.org/integration/fx-team/rev/1ad8dcecee7f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ad8dcecee7f

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 750381 [details] [diff] [review]
proposed fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression caused by bug 856814.
User impact if declined: ugly/broken UI for the developers toolbox tabs.
Testing completed (on m-c, etc.): landed in m-c.
Risk to taking this patch (and alternatives if risky): should be no risk.
String or IDL/UUID changes made by this patch: none.

Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/01fe1133726a

Comment 12

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0 (20130703181823)
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20130704 Firefox/24.0 (20130704004107)
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130703 Firefox/25.0 (20130703031323)