872483 - reftest text-svgglyphs/svg-glyph-mask.svg fails on all platforms

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

See bug 871961 comment 4.

Comment 1

[u459114]

In nsSVGMaskFrame::GetMaskForMaskedFrame, create SKIA draw target will fix this failure:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9aeee0d85bd4937de4e001a3d66505259bff7fd&selectedJob=67963930

Comment 2

[u459114]

Attachment: Bug 872483 - Correct svg-glyph-mask.svg by set stroke color to black.

Review commit: https://reviewboard.mozilla.org/r/103904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103904/

Comment 3

[u459114]

In nsSVGMaskFrame::GetMaskForMaskedFrame, replace CAIRO draw target by SKIA draw target. I saw some interesting rendering result in [1]
By turning on e10s, this test case can be pass. Which means the default value of stoke color is different by enable and disable e10s.


[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9aeee0d85bd4937de4e001a3d66505259bff7fd&selectedJob=67963930

Comment 4

[u459114]

Comment on attachment 8825831 [details]
Bug 872483 - Correct svg-glyph-mask.svg by set stroke color to black.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103904/diff/1-2/

Comment 5

[u459114]

Comment on attachment 8825831 [details]
Bug 872483 - Correct svg-glyph-mask.svg by set stroke color to black.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103904/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29f010e96be3
Correct svg-glyph-mask.svg by setting stroke color to black. r=me

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/29f010e96be3