872504 - java.lang.IllegalStateException: ListPreference requires an entries array and an entryValues array. at android.preference.ListPreference.onPrepareDialogBuilder(ListPreference.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ashish Namdev]

Attachment: alogcat.2013-05-15-18-49-43+0530.txt

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130511120803

Steps to reproduce:

When i was checking the setting option in Nightly for Android 24.0a1 Found title bar option there.

steps to Reproduce  :

1. Launch Nightly for android 24.0a1 build
2. tap on settings option.
3. tap on Title bar option.




Actual results:

It Crashed each time. i tried 5 times , it was reproducible 5/5 times


Expected results:

It Should show the function of Title bar option instead of crashing.

Comment 1

[Ashish Namdev]

Android Platform Version :  4.0.4 (ICS)

Please find the logs taken by alogcat 

File name  :  alogcat.2013-05-15-18-49-43+0530.txt

Comment 2

[Scoobidiver (away)]

Can you provide the crash ID from the about:crashes page, the logcat has no relevant info?

Comment 3

[Ashish Namdev]

Attachment: Alogcat logs taken again for the same crash

Logs for the same crash

Comment 4

[Ashish Namdev]

Hi Scoobidiver ,

I have attached another logs for the same ,
can you please check those and confirm if information can be extracted from those 

BR,
Ashish N

Comment 5

[Aaron Train [:aaronmt]]

Do you see the same thing if you disable Sync? I see plenty of exceptions Sync related in your logs.

Comment 6

[Ashish Namdev]

HI Scoobidiver ,

Please find the Information below form the about:crashes page

The latest Crash Id is  : 
Report ID :

bp-7028a3bc-fcc0-4e3f-a7ad392532130515

Time : 05/15/13 19:08


BR,
Ashish N

Comment 7

[Scoobidiver (away)]

(In reply to Ashish Namdev from comment #6)
> bp-7028a3bc-fcc0-4e3f-a7ad392532130515
You meant bp-7028a3bc-fcc0-4e3f-a7ad-392532130515 I assume.

Here is the stack trace:
java.lang.IllegalStateException: ListPreference requires an entries array and an entryValues array.
	at android.preference.ListPreference.onPrepareDialogBuilder(ListPreference.java:232)
	at android.preference.DialogPreference.showDialog(DialogPreference.java:293)
	at android.preference.DialogPreference.onClick(DialogPreference.java:264)
	at android.preference.Preference.performClick(Preference.java:939)
	at android.preference.PreferenceScreen.onItemClick(PreferenceScreen.java:202)
	at android.widget.AdapterView.performItemClick(AdapterView.java:292)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1394)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:3024)
	at android.widget.AbsListView$1.run(AbsListView.java:3830)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4517)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:993)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:760)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalStateException%3A+ListPreference+requires+an+entries+array+and+an+entryValues+array.+at+android.preference.ListPreference.onPrepareDialogBuilder%28ListPreference.java%29

Comment 8

[Aaron Train [:aaronmt]]

Reproducible.

--
HTC One (Android 4.1)
Nightly (05/15)

Comment 9

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

This try is applied the patch which is bug 868845 for landing: https://tbpl.mozilla.org/?tree=Try&rev=9ca359eaa754
I tried the test build. It does not crash with the reproducible steps. Maybe this is caused with other bugs?

But my main work is very busy now... I'm sorry, I can't research this crash detail at now.

Comment 10

[Scoobidiver (away)]

(In reply to Tetsuharu OHZEKI [:saneyuki_s] from comment #9)
> Maybe this is caused with other bugs?
I would have said part 3&4 of bug 868342 but it has only landed on inbound.

Comment 11

[Wesley Johnston (:wesj)]

This is fallout from bug 833625, which gave us three (mostly identical) preference.xml type files (yeah, that's not ideal). We need to update the other two...

Comment 12

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 13

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #11)
> This is fallout from bug 833625, which gave us three (mostly identical)
> preference.xml type files (yeah, that's not ideal). We need to update the
> other two...

Why do we have these redundant XML files? Can we file a bug to improve that?

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

And we'll need an uplift to fx23

Comment 15

[Chenxia Liu [:liuche]]

Follow-up Margaret requested in comment 13: Bug 872754

In short, the problem is that for nested settings screens, tablet UI requires Fragments, and pre-v11 phones don't work with these Fragments for preferences, so every screen that has nested screen has a "Fragment" version and a "non-Fragment" version. Bug 872329 should remove one of the three xml duplicates.

Comment 16

[Scoobidiver (away)]

There are about 85 crashes per build. It would be fine to land the patch.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fbf2f955014

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6fbf2f955014

Comment 19

[Ashish Namdev]

Hi ,

This Bus is fixed now ,
i checked in Nightly 24.0a1 (2013-05-19)

able to access Title Bar without any crash.
Thank you :)

BR,
Ashish N

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Prep for uplift please

Comment 21

[Wesley Johnston (:wesj)]

Comment on attachment 750012 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 778216
User impact if declined: crash
Testing completed (on m-c, etc.): on mc last week
Risk to taking this patch (and alternatives if risky): very low risk. just copying some code that was lost in unbitrotting
String or IDL/UUID changes made by this patch: none

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fc7d08eeb49c

Comment 23

[Ashish Namdev]

Hi ,

is this feature removed in Nightly 29.0a1

i am not seeing title Bar option in settings