872578 - UX failures in mochitest-2

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

You can run mochitest-2 from within your objdir via:

(py)make mochitest-2

Failures are looking like this:

005:14:06     INFO -  23 ERROR TEST-UNEXPECTED-FAIL | /tests/docshell/test/navigation/test_bug344861.html | window.open has correct width dimensions - got 575, expected 200

Comment 1

[:Gijs (he/him)]

Attachment: Hide customization panel so we don't force the window to be a certain size

So customization mode seems to force the window to not get any narrower than about 490-odd pixels, because bits of it have widths and the <deck> that contains it and the browser won't resize to be any smaller than its children, even if they're not the currently selected panel...

Rather than changing customization mode itself (which I'm not sure we want to do?) I've hidden it by default and then toggle it when we switch in/out of customization mode. Jared, do you think this is a reasonable way of doing it, or do you have a better idea?

This may not fix it completely, but then again, we only recently started seeing problems with the window *height* (it was previously only the width), namely after https://hg.mozilla.org/projects/ux/rev/7b73f1048bfe (see the Jamun tbpl for reference). Unfortunately, when I back out locally to one rev before that, I still don't get a passing test, not even for the height (which on tinderbox wasn't broken before that change, AFAICT). So I can't be sure this will be a complete fix for the width problem, but this change (or something similar to stop the customization panel from influencing window width so much) will be necessary anyway.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 750359 [details] [diff] [review]
Hide customization panel so we don't force the window to be a certain size

Review of attachment 750359 [details] [diff] [review]:
-----------------------------------------------------------------

Using hidden will disable and reenable any XBL bindings that are attached if the user enters and exits customization mode, but I don't think we're using any at the moment so this should be fine.

Comment 3

[:Gijs (he/him)]

Comment on attachment 750359 [details] [diff] [review]
Hide customization panel so we don't force the window to be a certain size

Pushed to UX: http://hg.mozilla.org/projects/ux/rev/a645c1fa2810

Comment 4

[:Gijs (he/him)]

We're done here. Hurray! :-)

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/a645c1fa2810