Closed
Bug 872635
Opened 11 years ago
Closed 11 years ago
DelayNode can drop its SelfReference a bit too late
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.74 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
In DelayNodeEngine::ProduceAudioBlock, when we compute mLeftOverData initially, we forget that we're going to consume WEBAUDIO_BLOCK_SIZE frames immediately, so mLeftOverData will be 128 frames more than needed, which means that the SelfReference is dropped a bit too late. This is OK for normal AudioContext, but for OfflineAudioContext, we may stop processing the graph immediately, which means that the SelfReference drop may never happen, which will cause leaks.
I have a simple patch to fix this. The tests that I'm adding in bug 836599 will test this.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #749954 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
Assignee | |
Comment 4•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•