Closed Bug 872635 Opened 7 years ago Closed 7 years ago

DelayNode can drop its SelfReference a bit too late

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

In DelayNodeEngine::ProduceAudioBlock, when we compute mLeftOverData initially, we forget that we're going to consume WEBAUDIO_BLOCK_SIZE frames immediately, so mLeftOverData will be 128 frames more than needed, which means that the SelfReference is dropped a bit too late.  This is OK for normal AudioContext, but for OfflineAudioContext, we may stop processing the graph immediately, which means that the SelfReference drop may never happen, which will cause leaks.

I have a simple patch to fix this.  The tests that I'm adding in bug 836599 will test this.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #749954 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/d4761c35c45e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.