872709 - Init list ordering build warnings for WebrtcVideoConduit in VideoConduit.h

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

New GCC build warnings on mozilla-inbound:
{
 6:26.78 In file included from /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:16:0:
 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h: In constructor 'mozilla::WebrtcVideoConduit::WebrtcVideoConduit()':
 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h: 'mozilla::WebrtcVideoConduit::mCurSendCodecConfig' will be initialized after
 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:220:21: warning: 'mozilla::WebrtcVideoConduit::mCurSendCodecConfig' will be initialized after [-Wreorder]
 6:26.78    VideoCodecConfig* mCurSendCodecConfig;
 6:26.78                      ^
 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h:   'webrtc::ViEBase* mozilla::WebrtcVideoConduit::mPtrViEBase'
 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:205:20: warning:   'webrtc::ViEBase* mozilla::WebrtcVideoConduit::mPtrViEBase' [-Wreorder]
 6:26.78    webrtc::ViEBase* mPtrViEBase;
 6:26.78                     ^
 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h:   when initialized here
 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:148:3: warning:   when initialized here [-Wreorder]
 6:26.78    WebrtcVideoConduit():
 6:26.78    ^
}

Looks like this was introduced by bug 863290.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

The mPTR* variables are declared between mRenderer and mEngineTransmitting, as shown here:
http://hg.mozilla.org/integration/mozilla-inbound/annotate/344e5e78adaa/media/webrtc/signaling/src/media-conduit/VideoConduit.h#l203
...so that's where they should be in the init list, too.  That fixes these warnings.

Comment 2

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: fix

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 750031 [details] [diff] [review]
fix

Review of attachment 750031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ecae7219a66

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ecae7219a66