Closed
Bug 872709
Opened 11 years ago
Closed 11 years ago
Init list ordering build warnings for WebrtcVideoConduit in VideoConduit.h
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [WebRTC][blocking-webrtc-][qa-])
Attachments
(1 file)
1.54 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
New GCC build warnings on mozilla-inbound: { 6:26.78 In file included from /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:16:0: 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h: In constructor 'mozilla::WebrtcVideoConduit::WebrtcVideoConduit()': 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h: 'mozilla::WebrtcVideoConduit::mCurSendCodecConfig' will be initialized after 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:220:21: warning: 'mozilla::WebrtcVideoConduit::mCurSendCodecConfig' will be initialized after [-Wreorder] 6:26.78 VideoCodecConfig* mCurSendCodecConfig; 6:26.78 ^ 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h: 'webrtc::ViEBase* mozilla::WebrtcVideoConduit::mPtrViEBase' 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:205:20: warning: 'webrtc::ViEBase* mozilla::WebrtcVideoConduit::mPtrViEBase' [-Wreorder] 6:26.78 webrtc::ViEBase* mPtrViEBase; 6:26.78 ^ 6:26.78 Warning: -Wreorder in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/src/media-conduit/VideoConduit.h: when initialized here 6:26.78 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/signaling/./src/media-conduit/VideoConduit.h:148:3: warning: when initialized here [-Wreorder] 6:26.78 WebrtcVideoConduit(): 6:26.78 ^ } Looks like this was introduced by bug 863290.
Updated•11 years ago
|
Assignee: nobody → gpascutto
Assignee | ||
Comment 1•11 years ago
|
||
The mPTR* variables are declared between mRenderer and mEngineTransmitting, as shown here: http://hg.mozilla.org/integration/mozilla-inbound/annotate/344e5e78adaa/media/webrtc/signaling/src/media-conduit/VideoConduit.h#l203 ...so that's where they should be in the init list, too. That fixes these warnings.
Assignee: gpascutto → dholbert
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #750031 -
Flags: review?(gpascutto)
Comment 3•11 years ago
|
||
Comment on attachment 750031 [details] [diff] [review] fix Review of attachment 750031 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #750031 -
Flags: review?(gpascutto) → review+
Updated•11 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-]
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ecae7219a66
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0ecae7219a66
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•11 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•