872802 - Legal documents should support L10n

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Wil Clouser [:clouserw]]

While filing bug 872799 and bug 872801 I noticed the legal docs don't indicate any language in their URLs or on disk.  I don't expect them to ever live in our .po files, but we will need to support translations of them.  We should put 'en' in the URL of the English documents for now and do any other preperation for localized docs that we need to.

P3 because we don't have the localized docs yet, but they have been shipped out to be translated already.

Comment 2

[Matt Basta [:basta]]

Perhaps we should create an API for this? The privacy policy + ToU add about 10k to our JS bundle. That's 10K per language that we'll be adding, possibly more.

Comment 3

[Wil Clouser [:clouserw]]

(In reply to Matt Basta [:basta] from comment #2)
> Perhaps we should create an API for this? The privacy policy + ToU add about
> 10k to our JS bundle. That's 10K per language that we'll be adding, possibly
> more.

I'm ok with keeping this server side.  Whether it's an API or just a flat file makes no difference to me either.  We just had the API triage though and I'd rather not have it sit for another week since it's a P2 and we've got the translations delivered

Comment 4

[Matt Basta [:basta]]

Since it's just static content, I think we can just put it in the /media directory and be fine. I talked this over with cvan and even he wasn't too grumpy about my design (!). 

Can you get the translations in a ZIP for me? I can get them taken care of.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to Matt Basta [:basta] from comment #4)
> Since it's just static content, I think we can just put it in the /media
> directory and be fine. I talked this over with cvan and even he wasn't too
> grumpy about my design (!). 
> 
> Can you get the translations in a ZIP for me? I can get them taken care of.

Looks like ToS is still waiting on legal in bug 855551.

Comment 6

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/3060665adb9de5ab94c5a0542696c20133e1354e

Steps to QA:
1. Visit the ToS/Privacy Policy
2. Open your web console
3. Look for a "GETting https://somethingsomethingcdn/media/docs/privacy/en-US.html"

How to add translations:
1. Convert the translations to HTML
2. Put them in zamboni's /media/docs/(privacy|terms)/ directory where the name is "<lang>.html". <lang> should be the locale code of the language as it's used by the localizers.

Comment 7

[Victor Carciu]

(In reply to Matt Basta [:basta] from comment #6)
> https://github.com/mozilla/fireplace/commit/
> 3060665adb9de5ab94c5a0542696c20133e1354e
> 
> Steps to QA:
> 1. Visit the ToS/Privacy Policy
> 2. Open your web console
> 3. Look for a "GETting
> https://somethingsomethingcdn/media/docs/privacy/en-US.html"
> 
> How to add translations:
> 1. Convert the translations to HTML
> 2. Put them in zamboni's /media/docs/(privacy|terms)/ directory where the
> name is "<lang>.html". <lang> should be the locale code of the language as
> it's used by the localizers.

I can see this line in console : http://screencast.com/t/uw5JzPKPfV , can I mark the bug as verified based on this test?

Comment 8

[Wil Clouser [:clouserw]]

There are a lot of dependent bugs which will verify this for free, fwiw.

Comment 9

[Wil Clouser [:clouserw]]

Matt: can you link to the directory where I need to put the localized docs?

Comment 10

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/tree/master/media/docs