Autophone - eliminate DeviceManagerSUT in favor of DroidSUT

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 750219 [details] [diff] [review]
patch v1

bug 862508 introduced the use of DroidSUT.launchFennec but didn't completely eliminate the use of DeviceManagerSUT. This patch does eliminate DeviceManagerSUT and makes sure to specify retryLimit in phonetest.py when it initializes its instance.
Attachment #750219 - Flags: review?(mcote)

Comment 1

6 years ago
Comment on attachment 750219 [details] [diff] [review]
patch v1

Review of attachment 750219 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: phonetest.py
@@ +91,4 @@
>              self._dm = DroidSUT(self.phone_cfg['ip'],
>                                  self.phone_cfg['sutcmdport'],
> +                                retryLimit=8)
> +            self._dm.debug = self.user_cfg['debug']

"debug" has been deprecated in favour of logLevel (using mozlog levels), so maybe we should switch while we're here? (And a couple other places in worker.py).
Attachment #750219 - Flags: review?(mcote) → review+
(Assignee)

Comment 2

6 years ago
https://github.com/mozilla/autophone/commit/f1d7600328143c245e20ee627e25ef8ca938958b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.