873001 - Update libpng to version 1.5.16

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Glenn Randers-Pehrson]

Libpng 1.5.16 is planned for release on May 23.  The PNG group is still working on some issues with libpng-1.6.3 so we should upgrade to 1.5.16 in the meantime.

Comment 1

[Glenn Randers-Pehrson]

Attachment: v00-preview-of-update-libpng-to-version-1.5.16rc01

This is a preview of the update to libpng-1.5.16 (just the C files that were changed from libpng-1.5.15 in libpng-1.5.16rc01), for testing.  The only significant change is in the ARM-neon files in the arm subdirectory.

Comment 2

[Glenn Randers-Pehrson]

Marking as a blocker for bug #832390 (ARM support).  I don't know if it actually blocks that bug but it should be checked, because the arm code will change in libpng-1.5.16.

Comment 3

[Glenn Randers-Pehrson]

It would be good to have a try server run that finds any problems here before we release libpng-1.6.3 on Thursday.

Comment 4

[Glenn Randers-Pehrson]

I should have said, "before we release libpng-1.5.16 on Thursday."

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Your wish is my command :)
https://tbpl.mozilla.org/?tree=Try&rev=2e4974ff630a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

BTW, you're better off requesting info of a certain person (namely me in this case) so it gets noticed.

Comment 7

[Glenn Randers-Pehrson]

Thanks.  One of the optimized ARM tests timed out but it's otherwise mostly green, so I guess we're OK.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Yeah, that's just the usual silliness.

Comment 9

[Glenn Randers-Pehrson]

Attachment: v01-update-libpng-to-version-1.5.16

Need a tryserver run, please.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=39b6d28f0154

Comment 11

[Glenn Randers-Pehrson]

Comment on attachment 758602 [details] [diff] [review]
v01-update-libpng-to-version-1.5.16

Try server all green but one which seems unrelated.  The only significant change from 1.5.15 to 1.5.16 is in the ARM-NEON support.  r?

Comment 12

[Joe Drew (not getting mail)]

Comment on attachment 758602 [details] [diff] [review]
v01-update-libpng-to-version-1.5.16

Review of attachment 758602 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01458e7eb707

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Glenn, I don't see where the ARM files ever got added to a Makefile.in or moz.build? The logs agree that filter_neon.S isn't being compiled on Android/B2G.

Comment 15

[Glenn Randers-Pehrson]

Bug #832390 is supposed to enable the ARM support.  It contains a patch to libpng's Makefile.in.

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/01458e7eb707

Comment 17

[Glenn Randers-Pehrson]

This morning my inbox is flooded with reports like this.  The other two bugs in the report are locked so I don't know what they are about.


Regression: Mozilla-Inbound - Dromaeo (CSS) - MacOSX 10.7 - 6.4% decrease
-------------------------------------------------------------------------
    Previous: avg 3750.069 stddev 12.024 of 12 runs up to revision 72fbfb2f8e51
    New     : avg 3509.904 stddev 24.484 of 12 runs since revision be065b3be5fe
    Change  : -240.165 (6.4% / z=19.975)
    Graph   : http://mzl.la/ZQomiM

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=72fbfb2f8e51&tochange=be065b3be5fe

Changesets:
  * http://hg.mozilla.org/integration/mozilla-inbound/rev/7df36088f645
    : Kannan Vijayan <[e-mail]> - Bug 877287. r=h4writer
    : http://bugzilla.mozilla.org/show_bug.cgi?id=877287

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/01458e7eb707
    : Glenn Randers-Pehrson <[e-mail]> - Bug 873001 - Update libpng to version 1.5.16. r=joe
    : http://bugzilla.mozilla.org/show_bug.cgi?id=873001

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/be065b3be5fe
    : Kannan Vijayan <[e-mail]> - Bug 870034. r=bhackett
    : http://bugzilla.mozilla.org/show_bug.cgi?id=870034

Bugs:
  * http://bugzilla.mozilla.org/show_bug.cgi?id=873001 - Update libpng to version 1.5.16
  * http://bugzilla.mozilla.org/show_bug.cgi?id=870034
  * http://bugzilla.mozilla.org/show_bug.cgi?id=877287

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Known regression from bug 877287 :)

Comment 19

[Glenn Randers-Pehrson]

Thanks, so we were just caught in the cross fire.  Marking "Verified fixed".

Comment 20

[Glenn Randers-Pehrson]

I forgot to update apng.patch.  I'm pretty sure the existing one will work against libpng-1.5.16 but I need to test that.