Closed Bug 873037 Opened 7 years ago Closed 7 years ago

Cleaning update directory should be changed from CleanUpdatesDir to CleanUpdateDirectories for Seamonkey

Categories

(SeaMonkey :: Installer, defect)

x86_64
Windows 8
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: bbondy, Assigned: mcsmurf)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

In Windows, the update directory was changed to be a subdirectory of C:\Users\Brian\AppData\Local\Mozilla\updates based on the taskbarIDs value for the install path.

See bug 572162 for more information.

CleanUpdatesDir is obsolete and will clear the old update directory only.
CleanUpdateDirectories should be used instead now.
Summary: Cleaning update directory should be changed from CleanUpdatesDir to CleanUpdateDirectories → Cleaning update directory should be changed from CleanUpdatesDir to CleanUpdateDirectories for Seamonkey
Blocks: 873043
Attached patch Patch (obsolete) — Splinter Review
Assignee: installer → bugzilla
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Attachment #751737 - Attachment is obsolete: true
Comment on attachment 751738 [details] [diff] [review]
Patch

Ian: Can you review this installer patch? It fixes the installer to use new cleanup functions for the new update directories (it uses hash values to create/delete the update directory for the local installation). Due to that the hash value needs to be initialized before calling the new CleanUpdateDirectories function, therefor the InitHashAppModelId call got moved. In uninstaller.nsi the un.CleanUpdateDirectories call got created/moved to a few lines below the call to InitHashAppModelId (though I think strictly this would not have been necessary, but it's no problem either).
Attachment #751738 - Flags: review?(iann_bugzilla)
Attachment #751738 - Flags: review?(iann_bugzilla) → review+
Whoops, looks like I forgot to check this in! Pushed: https://hg.mozilla.org/comm-central/rev/afd06f7ad97e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in before you can comment on or make changes to this bug.