873037 - Cleaning update directory should be changed from CleanUpdatesDir to CleanUpdateDirectories for Seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

In Windows, the update directory was changed to be a subdirectory of C:\Users\Brian\AppData\Local\Mozilla\updates based on the taskbarIDs value for the install path.

See bug 572162 for more information.

CleanUpdatesDir is obsolete and will clear the old update directory only.
CleanUpdateDirectories should be used instead now.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 751738 [details] [diff] [review]
Patch

Ian: Can you review this installer patch? It fixes the installer to use new cleanup functions for the new update directories (it uses hash values to create/delete the update directory for the local installation). Due to that the hash value needs to be initialized before calling the new CleanUpdateDirectories function, therefor the InitHashAppModelId call got moved. In uninstaller.nsi the un.CleanUpdateDirectories call got created/moved to a few lines below the call to InitHashAppModelId (though I think strictly this would not have been necessary, but it's no problem either).

Comment 4

[Frank Wein [:mcsmurf]]

Whoops, looks like I forgot to check this in! Pushed: https://hg.mozilla.org/comm-central/rev/afd06f7ad97e