873134 - Notify install success before starting to download package

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

mozIDOMApplicationRegistry2.installPackage is supposed to trigger the DOMRequest.onsuccess callback and mozIDOMApplicationMgmt.oninstall event *before* starting to download the package of the app. We are currently not doing it :(.

To be honest, I don't even know how is this currently working for Gaia :\

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Actually, I'd like to know how Gaia is working before nominating for tef+

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Fix

Comment 3

[Jason Smith [:jsmith]]

Julien would be a good person to ask about that.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Well, I'm quite sure it works in gaia :)

but I follow your reasoning, Fabrice should know better.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

So it seems that this is working on b2g18 but not in m-i, birch or m-c. The reason seems to be Bug 856131

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

With the attached patch we notify via 'mgmt.oninstall' and 'DOMRequest.onsuccess' as soon as the app is stored in the apps registry for both, hosted and packaged apps. This way consumers of the mgmt API will receive the app object along with the 'mgmt.oninstall' event and will be able to listen to the package download events as expected.
 
James, I am not sure if you expect 'aInstallSuccessCallback' to be fired along with the 'oninstall' and the 'DOMRequest.onsuccess' events or once the package download is completed.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

aInstallSuccessCallback is supposed to be called after the end of the download.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Ok, thanks James. That's the way the attached patch works.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aca56671754a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aca56671754a