Closed
Bug 873206
Opened 13 years ago
Closed 13 years ago
SecReview: thimble.webmaker.org bleaching whitelists
Categories
(mozilla.org :: Security Assurance: Review Request, task)
mozilla.org
Security Assurance: Review Request
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: mgoodwin)
Details
(Whiteboard: [completed secreview][score:medium][Web])
We'd like to deploy a newly updated thimble.webmaker.org june 15th, and have widened the permissions in terms of tags and tag attributes to what still seemed safe. However, we can't be certain that the HTML elements and attribute we're allowing won't lead to obvious page exploits.
The repo for this is http://github.com/mozilla/thimble.webmaker.org, with the relevant code in the https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/bleach.js module.
This review technically doesn't block any other work, but the sooner it passes review the sooner we know whether we need to modify anything. The slated release date is June 15th (for the Mozilla Summer Campaign) so we'd ideally know whether we can use these lists or whether they need tighening by June 1st.
I can act as the point of contact for this bug (Pomax on IRC), but it will be good to include David Humphrey (:humph) and Mark Goodwin (:mgoodwin) to the CC list, as they are involved on the product and security side, respectively, for our webmaker.org components.
Updated•13 years ago
|
Whiteboard: [pending secreview] → [pending secreview][triage needed]
Updated•13 years ago
|
Assignee: nobody → mgoodwin
Updated•13 years ago
|
Whiteboard: [pending secreview][triage needed] → [pending secreview]
| Assignee | ||
Comment 1•13 years ago
|
||
See also bug 866704.
Is there anything else needed other than what's been done in the above?
Flags: needinfo?(pomax)
I think that was all we needed, thanks!
Flags: needinfo?(pomax)
| Assignee | ||
Comment 3•13 years ago
|
||
Closing secreview; see bug 866704 for comments.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [pending secreview] → [completed secreview][score:medium]
Updated•13 years ago
|
Whiteboard: [completed secreview][score:medium] → [completed secreview][score:medium][Web]
You need to log in
before you can comment on or make changes to this bug.
Description
•