873365 - [Cost Control]The FTE screen fires or moves fastly.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Leo]

1. Title : The FTE screen fires or moves fastly.
2. Precondition : 
3. Tester's Action : Insert non configured SIM card and click on Usage app.
4. Detailed Symptom (ENG.) :The Welcome screen will show the screen with "Information shown on Usage comes directly..." paragraph first and again it will show the "Save money by keeping.." paragaph along with "Information shown on Usage comeas directly..." paragraph.
Due to which user may feel loss of information due fast movement of scrrens. 
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: e882f5d6649ad22dbe0f8e8e8726c84cce2a2d4d
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Attached Screenshot

Comment 2

[Salvador de la Puente González [:salva]]

There is no movement between screens, the problem is the bold paragraph is dynamically added so it produces a minor reflow.

Comment 3

[Leo]

I changed the bold paragraph to show statically instead of adding dynamically,but still the problem exist, showing the black screen.

Comment 4

[Salvador de la Puente González [:salva]]

The black screen is normal since you are loading first the application and it have a black neutral screen to hide the UI changes until all is ready (bug 828155). Then the application realizes the FTE should show so it change to that URL. This produces a flash to a blank page (a white screen) that is filled.

You are noticing a change because, if you don't complete the FTE, then Gaia stores a screenshot of the first screen of FTE. As Gaia is not aware about what's happening inside the application, it first shows the screenshot, then the app displays the black-screen, now change to the first page of the FTE.

We can do something like showing another neutral screen, but little more.

The bug is nominated for tracking but it is not a priority.

Comment 5

[Leo]

Hi Salva,

In Master and Leo/V1train we did small below workaround for this issue.

1.While launching the fte.html,we are able to send the application mode.(Ex:datausage)
2.Once we get the mode i changed the bold paragarph to visible.

With the above changes

In Master:The flashing is not present.
In Leo/V1train:The Fte screen is shown and Black screen and after that again Fte screen.

Comment 6

[Salvador de la Puente González [:salva]]

You're right, why don't you propose a patch for review? Maybe I can try with Vivo a tweak your patch to add the not DATA_USAGE_ONLY functionality. Anyway, in progress changes will change the way we are detecting current application mode.

Comment 7

[Leo]

Attachment: Patch for review

I made the changes for both Vivo and Non-Vivo.
Please review and let me know if i need to modify anything.

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 755307 [details] [diff] [review]
Patch for review

Sireesha, the new behavior works perfectly. I have some comments about the code, so make this patch a PR in order to follow the contribution guidelines [1] and I will grant you the r+.

Smart work!

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch

Comment 9

[Leo]

Attachment: Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Comment 10

[Salvador de la Puente González [:salva]]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Review comments in GitHub.

Comment 11

[Leo]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Hi Salva,

I squashed the review changes.But the build failed again.
if this fail is due to my commit please let me know.
And i did make lint and removed lint errors manually.

Thanks for your support.

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Check comments in GitHub,

Comment 13

[Leo]

Hi Salva,

I renamed the function.Please check it.

Comment 14

[Leo]

Hi Salva,

This bug depends on Bug-866174 and patch is not uplifted to V1train and there is no project flag for this issue(Bug-866174).
So,would you please uplift bug 866174 patch to V1train.

Comment 15

[Salvador de la Puente González [:salva]]

This bug should not depend on bug 866174 at code level because that bug does not modify Usage code. Furthermore, I have no authority to uplift bugs if I'm not asked for and that bug is not even flagged to uplift to v1.1.

Once you get the r+ for this bug (I need to pass the tests manually as Travis is failing for some reason), let's try to land this and only ask to land other blockers if we find any impediment.

Comment 16

[Salvador de la Puente González [:salva]]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Tests are not passing. The following errors are provided:
Error: Please, getApplicationMode() is being called. Provide the key `applicationMode` in the constructor config object to mock it.

This is because now, as you call getApplicationMode() starting the FTE, you need to provide a mockup. Review the unit tests to update them according the new needs.

The code looks good now!

Comment 17

[Leo]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Hi Salva,

Please review the testcase.

Thanks for your support.

Comment 18

[Salvador de la Puente González [:salva]]

Comment on attachment 756396 [details] [diff] [review]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/10125

Perfect. Code looks clear, tests run smoothly.
Good work Sireesha!
Thank you.

Comment 19

[Salvador de la Puente González [:salva]]

Master: fe089acc9b6156470355a5e1b0ff8eac76ce2dfb

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 fe089acc9b6156470355a5e1b0ff8eac76ce2dfb
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 21

[Salvador de la Puente González [:salva]]

After uplifting bug 846258, this applies cleanly:
v1-train: a5ca81e9566bd4db8fc55a74cad9063166e8c00d