873431 - App launching splash screen displays incorrectly on hi-dpi devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chris Lord [:cwiiis]]

The new splash screen for cold app launch displays a small screenshot centered in the screen with space all around on a Geeksphone Peak (and I would assume other hidpi devices)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

FYI, dev-gaia "App loading splash image and multi-resolution".

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/10065

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 755250 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/10065

Can't we simply add bigger screenshots and make the window manager more aware of the size of the screen?

Comment 5

[Chris Lord [:cwiiis]]

An interesting thing that the WIMM One (an Android-based smart watch) does for this is have a separate 'simple' layout file that it renders while loading the proper layout/app.

The equivalent would be to allow specifying a splash page that renders very quickly, which we replace with the full app once it's ready.

The benefit would be that we wouldn't have to worry about maintaining splash screens for various different resolutions, or providing a lesser experience, though I don't know how technically difficult this would be in the current framework.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #4)
> Comment on attachment 755250 [details] [review]
> Github: https://github.com/mozilla-b2g/gaia/pull/10065
> 
> Can't we simply add bigger screenshots and make the window manager more
> aware of the size of the screen?

Hi, Vivien, long time no see!

No, the solution won't scale. We have kind of went through that in dev-gaia, and you were CC'd the whole time. It would be appreciated if you raise your solution in the right place and in the right time.

(In reply to Chris Lord [:cwiiis] from comment #5)
> An interesting thing that the WIMM One (an Android-based smart watch) does
> for this is have a separate 'simple' layout file that it renders while
> loading the proper layout/app.
> 
> The equivalent would be to allow specifying a splash page that renders very
> quickly, which we replace with the full app once it's ready.

No one is prevent the apps from implementing that on their own.

> The benefit would be that we wouldn't have to worry about maintaining splash
> screens for various different resolutions, or providing a lesser experience,
> though I don't know how technically difficult this would be in the current
> framework.

Yes.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am tempted to mark this as hd? because this is one thing that prevent us from align features between v1.1hd and master.

We need a resolution here. Vivien, would you accept the patch as-is and let's move on the roll out a proper feature on a future bug, or we should convert this bug to the proper fix discussed on dev-gaia?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 755250 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/10065

Thanks for your patience.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Rebasing...

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/a47faa4a8a11cbaee004bf4f6cc2d7645dba569f