Last Comment Bug 873447 - expose IAccessible2 checkable state
: expose IAccessible2 checkable state
Status: RESOLVED FIXED
[mentor=surkov.alexander@gmail.com][l...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla24
Assigned To: Marcos A. Di Pietro
:
:
Mentors:
Depends on: IA2_1.3
Blocks: ia2
  Show dependency treegraph
 
Reported: 2013-05-17 06:01 PDT by alexander :surkov
Modified: 2013-06-04 07:15 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (986 bytes, patch)
2013-06-03 19:23 PDT, Marcos A. Di Pietro
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2013-05-17 06:01:14 PDT
IA2_STATE_CHECKABLE (a plain mapping)
Comment 1 alexander :surkov 2013-05-26 18:54:08 PDT
(In reply to alexander :surkov from comment #0)
> IA2_STATE_CHECKABLE (a plain mapping)

map states::CHECKED into IA2_STATE_CHECKABLE (msaa/AccessibleWrap::get_states)
Comment 2 MikeLing 2013-06-02 16:14:03 PDT
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Comment 3 David Bolter [:davidb] 2013-06-03 11:43:02 PDT
(In reply to MikeLing from comment #2)
> Hi I am interested in working on this bug,but it's my first time to work on
> with debug

Thanks! What do you mean by 'with debug'?
Comment 4 Marcos A. Di Pietro 2013-06-03 13:26:17 PDT
I have a patch for this, please go ahead and assign me this bug.
Comment 5 alexander :surkov 2013-06-03 19:12:35 PDT
(In reply to Marcos A. Di Pietro from comment #4)
> I have a patch for this, please go ahead and assign me this bug.

done. I hope it's ok with MikeLing who was interested working on it but we work with him in another bug already, it should be ok
Comment 6 Marcos A. Di Pietro 2013-06-03 19:23:05 PDT
Created attachment 757761 [details] [diff] [review]
Patch v1

Maps states::CHECKED to IA2_STATE_CHECKABLE in msaa/AccessibleWrap.cpp::get_states
Comment 7 alexander :surkov 2013-06-03 19:24:33 PDT
Comment on attachment 757761 [details] [diff] [review]
Patch v1

Review of attachment 757761 [details] [diff] [review]:
-----------------------------------------------------------------

plain and simple, thank you for the fix!
Comment 8 Marco Zehe (:MarcoZ) 2013-06-04 01:56:09 PDT
Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/70e5bad55544
Comment 9 Ed Morley [:emorley] 2013-06-04 07:15:58 PDT
https://hg.mozilla.org/mozilla-central/rev/70e5bad55544

Note You need to log in before you can comment on or make changes to this bug.