The default bug view has changed. See this FAQ.

Implement IA2_RELATION_NODE_PARENT_OF

RESOLVED FIXED in mozilla24

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: surkov, Assigned: xuku)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla24
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
a plain mapping into internal relation (node_parent_of)
(Reporter)

Updated

4 years ago
No longer blocks: 614570
Depends on: 614570
(Assignee)

Comment 1

4 years ago
I saw this:

case nsIAccessibleRelation::RELATION_NODE_CHILD_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_CHILD_OF);
   break;

and created a mirror parent entry right below it:

case nsIAccessibleRelation::RELATION_NODE_PARENT_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_PARENT_OF);
  break;

Is this all the implementation necessary, or do I need to go farther back and add entries for RELATION_NODE_PARENT_OF where only RELATION_CHILD_PARENT_OF is used?
I believe you need to add it to the list at the bottom of ia2AccessibleRelation.h as well
(Assignee)

Comment 3

4 years ago
Created attachment 751956 [details] [diff] [review]
Fix Attempt
Attachment #751956 - Flags: review?(trev.saunders)
(Reporter)

Updated

4 years ago
Blocks: 368873
(Reporter)

Comment 4

4 years ago
trev, ping
Attachment #751956 - Flags: review?(trev.saunders) → review+
(Reporter)

Updated

4 years ago
Assignee: nobody → zach.xuku
(Reporter)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4461b9480b

thank you for the fix, Zach. You can take a look at other IA2 bugs if you like.
(Assignee)

Comment 6

4 years ago
No problem! I'll check them out once I get back in town in about ten days.
https://hg.mozilla.org/mozilla-central/rev/2a4461b9480b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.