Last Comment Bug 873453 - Implement IA2_RELATION_NODE_PARENT_OF
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla24
Assigned To: Zach (:xuku)
: alexander :surkov
Depends on: IA2_1.3
Blocks: ia2
  Show dependency treegraph
Reported: 2013-05-17 06:06 PDT by alexander :surkov
Modified: 2013-05-23 04:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix Attempt (2.23 KB, patch)
2013-05-20 18:48 PDT, Zach (:xuku)
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description User image alexander :surkov 2013-05-17 06:06:37 PDT
a plain mapping into internal relation (node_parent_of)
Comment 1 User image Zach (:xuku) 2013-05-20 16:21:58 PDT
I saw this:

case nsIAccessibleRelation::RELATION_NODE_CHILD_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_CHILD_OF);

and created a mirror parent entry right below it:

case nsIAccessibleRelation::RELATION_NODE_PARENT_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_PARENT_OF);

Is this all the implementation necessary, or do I need to go farther back and add entries for RELATION_NODE_PARENT_OF where only RELATION_CHILD_PARENT_OF is used?
Comment 2 User image Trevor Saunders (:tbsaunde) 2013-05-20 16:54:11 PDT
I believe you need to add it to the list at the bottom of ia2AccessibleRelation.h as well
Comment 3 User image Zach (:xuku) 2013-05-20 18:48:13 PDT
Created attachment 751956 [details] [diff] [review]
Fix Attempt
Comment 4 User image alexander :surkov 2013-05-21 19:09:49 PDT
trev, ping
Comment 5 User image alexander :surkov 2013-05-22 22:14:17 PDT

thank you for the fix, Zach. You can take a look at other IA2 bugs if you like.
Comment 6 User image Zach (:xuku) 2013-05-23 04:49:05 PDT
No problem! I'll check them out once I get back in town in about ten days.
Comment 7 User image Ed Morley [:emorley] 2013-05-23 04:52:17 PDT

Note You need to log in before you can comment on or make changes to this bug.