Closed Bug 873453 Opened 6 years ago Closed 6 years ago

Implement IA2_RELATION_NODE_PARENT_OF

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: surkov, Assigned: xuku)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file)

a plain mapping into internal relation (node_parent_of)
No longer blocks: IA2_1.3
Depends on: IA2_1.3
I saw this:

case nsIAccessibleRelation::RELATION_NODE_CHILD_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_CHILD_OF);
   break;

and created a mirror parent entry right below it:

case nsIAccessibleRelation::RELATION_NODE_PARENT_OF:
  *aRelationType = ::SysAllocString(IA2_RELATION_NODE_PARENT_OF);
  break;

Is this all the implementation necessary, or do I need to go farther back and add entries for RELATION_NODE_PARENT_OF where only RELATION_CHILD_PARENT_OF is used?
I believe you need to add it to the list at the bottom of ia2AccessibleRelation.h as well
Attached patch Fix AttemptSplinter Review
Attachment #751956 - Flags: review?(trev.saunders)
Blocks: ia2
trev, ping
Attachment #751956 - Flags: review?(trev.saunders) → review+
Assignee: nobody → zach.xuku
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4461b9480b

thank you for the fix, Zach. You can take a look at other IA2 bugs if you like.
No problem! I'll check them out once I get back in town in about ten days.
https://hg.mozilla.org/mozilla-central/rev/2a4461b9480b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.