Closed
Bug 873453
Opened 12 years ago
Closed 12 years ago
Implement IA2_RELATION_NODE_PARENT_OF
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: surkov, Assigned: xuku)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file)
2.23 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
a plain mapping into internal relation (node_parent_of)
Reporter | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
I saw this:
case nsIAccessibleRelation::RELATION_NODE_CHILD_OF:
*aRelationType = ::SysAllocString(IA2_RELATION_NODE_CHILD_OF);
break;
and created a mirror parent entry right below it:
case nsIAccessibleRelation::RELATION_NODE_PARENT_OF:
*aRelationType = ::SysAllocString(IA2_RELATION_NODE_PARENT_OF);
break;
Is this all the implementation necessary, or do I need to go farther back and add entries for RELATION_NODE_PARENT_OF where only RELATION_CHILD_PARENT_OF is used?
Comment 2•12 years ago
|
||
I believe you need to add it to the list at the bottom of ia2AccessibleRelation.h as well
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #751956 -
Flags: review?(trev.saunders)
Reporter | ||
Comment 4•12 years ago
|
||
trev, ping
Updated•12 years ago
|
Attachment #751956 -
Flags: review?(trev.saunders) → review+
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → zach.xuku
Reporter | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4461b9480b
thank you for the fix, Zach. You can take a look at other IA2 bugs if you like.
Assignee | ||
Comment 6•12 years ago
|
||
No problem! I'll check them out once I get back in town in about ten days.
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•