Closed Bug 873579 Opened 7 years ago Closed 6 years ago

Remove existing about:home view

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: sriram, Assigned: sriram)

References

Details

(Whiteboard: fixed-fig)

Attachments

(1 file)

The long vertical about:home should go. Now that ViewPager is added, we can remove this single page and start adding individual pages.

(Sorry :bnicholson, but this should go :( )
Assignee: nobody → sriram
Attached patch PatchSplinter Review
This hides the widget/AboutHome from the HomePager. Later when we add individual pages, we can add the update() functionalities. The background is all white now.
Attachment #751147 - Flags: review?(bnicholson)
Comment on attachment 751147 [details] [diff] [review]
Patch

Review of attachment 751147 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/HomePager.java
@@ +4,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  package org.mozilla.gecko.home;
>  
> +import org.mozilla.gecko.widget.AboutHome;

Drive-by: I think we can get rid of this AboutHome class altogether, since we're not really using most of it anymore. The parts of it we do need (like UpdateFlags) could move into HomePager.

We could also kill off all the views that are in it. Maybe we want to keep them around as we transition some of their contents into the new about:home, but all that code still exists on mozilla-central, so we always have that as a reference.

I suppose we also need to kill off all the AwesomeBar related stuff at some point, too... so many things are going to go away :)
Comment on attachment 751147 [details] [diff] [review]
Patch

Review of attachment 751147 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/HomePager.java
@@ +4,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  package org.mozilla.gecko.home;
>  
> +import org.mozilla.gecko.widget.AboutHome;

I agree that we should kill off AboutHome, and we should probably move/delete all abouthome/awesomebar classes ASAP. If we leave these files as they are, they'll silently be updated when merging from m-c. We want to avoid that since there may be incoming fixes that we end up dropping when these files do eventually get deleted. Since you've gotten rid of the AboutHome dependencies, can you file a follow-up to remove all AboutHome/AwesomeBar-related code?
Attachment #751147 - Flags: review?(bnicholson) → review+
(In reply to Brian Nicholson (:bnicholson) from comment #3)
> Comment on attachment 751147 [details] [diff] [review]
> Patch
> 
> Review of attachment 751147 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/home/HomePager.java
> @@ +4,5 @@
> >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> >  
> >  package org.mozilla.gecko.home;
> >  
> > +import org.mozilla.gecko.widget.AboutHome;
> 
> I agree that we should kill off AboutHome, and we should probably
> move/delete all abouthome/awesomebar classes ASAP. If we leave these files
> as they are, they'll silently be updated when merging from m-c. We want to
> avoid that since there may be incoming fixes that we end up dropping when
> these files do eventually get deleted. Since you've gotten rid of the
> AboutHome dependencies, can you file a follow-up to remove all
> AboutHome/AwesomeBar-related code?

I filed bug 876712 for killing off the AwesomeBar code, but we could expand it's scope to kill off the AboutHome stuff, too.
Whiteboard: fixed-fig
https://hg.mozilla.org/mozilla-central/rev/762d1865d454
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.