873615 - DispatchCertVerificationResult addrefs a JS listener off the main thread

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Josh Matthews [:jdm]]

The stack trace on Mac is:
Frame 	Module 	Signature 	Source
0 	XUL 	nsXPCWrappedJS::AddRef 	js/xpconnect/src/XPCWrappedJS.cpp:155
1 	XUL 	nsCertVerificationJob::Run 	obj-firefox/x86_64/dist/include/nsCOMPtr.h:566
2 	XUL 	nsCertVerificationThread::Run 	security/manager/ssl/src/nsCertVerificationThread.cpp:142
3 	libnss3.dylib 	null_signal_handler 	
4 	libnss3.dylib 	_pt_root 	
5 	libsystem_c.dylib 	libsystem_c.dylib@0x147a2 	
6 	libsystem_c.dylib 	libsystem_c.dylib@0x11e1 	
7 	libnss3.dylib 	null_signal_handler

Comment 1

[Josh Matthews [:jdm]]

Attachment: Make certificate verification avoid addrefing JS-wrapped listeners off the main thread.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 751164 [details] [diff] [review]
Make certificate verification avoid addrefing JS-wrapped listeners off the main thread.

Review of attachment 751164 [details] [diff] [review]:
-----------------------------------------------------------------

This seems OK to me. nsCertVerificationJob::Run does always dispatch the callback to the main thread.

::: security/manager/ssl/src/nsNSSCertificate.cpp
@@ +1409,2 @@
>  nsNSSCertificate::RequestUsagesArrayAsync(nsICertVerificationListener *aResultListener)
>  {

NS_ENSURE_TRUE(NS_IsMainThread(), NS_ERROR_NOT_SAME_THREAD) here.

Comment 3

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7aa62774568

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7aa62774568