Closed
Bug 773610
Opened 12 years ago
Closed 9 years ago
Fix consumers that AddRef XPCWrappedJS off-main-thread
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: bholley, Assigned: bholley)
References
Details
Split off from bug 771074.
Assignee | ||
Comment 1•12 years ago
|
||
Fixed various consumers and pushed to try with fatal asserts. Let's see what our test suite hits:
https://tbpl.mozilla.org/?tree=Try&rev=7d5f0d9086ab
Assignee | ||
Comment 2•12 years ago
|
||
Fixed more and pushed again:
https://tbpl.mozilla.org/?tree=Try&rev=c3b0a1617a2a
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
Note that my patches are in a github branch here: https://github.com/bholley/mozilla-central/commits/wrappedjs_dethread
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Comment 7•12 years ago
|
||
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #7)
> https://tbpl.mozilla.org/?tree=Try&rev=0d1e656367ce
Nice, linux is green! It's pretty likely that there are going to be some platform-specific failures here, so let's check those now:
https://tbpl.mozilla.org/?tree=Try&rev=b753c766c5ef
Assignee | ||
Comment 9•12 years ago
|
||
This is hitting an out-of-bounds nsTArray on windows that MOZ_ASSERTs before we get a stack. I replaced it with an NS_ASSERTION, which should hopefully dump a stack:
https://tbpl.mozilla.org/?tree=Try&rev=1bed20aef921
Assignee | ||
Comment 10•12 years ago
|
||
Ugh, the stacks here are being supremely unhelpful, and this doesn't reproduce locally for me.
I'm pretty sure it's related to one of the three patches that do something with nsTArray, so I'm pushing those three separately to try to see if we can get some more data:
https://tbpl.mozilla.org/?tree=Try&rev=1ff159e0aae5
https://tbpl.mozilla.org/?tree=Try&rev=e8bd699b2ce6
https://tbpl.mozilla.org/?tree=Try&rev=8193765f4429
Assignee | ||
Comment 11•12 years ago
|
||
I'm starting to think that the issue here might just be that nsTArray asserts against out-of-bounds access but nsCOMArray doesn't. Let's test that theory:
https://tbpl.mozilla.org/?tree=Try&rev=2795f3a43e11
Assignee | ||
Comment 12•12 years ago
|
||
@#$% warnings-as-errors - https://tbpl.mozilla.org/?tree=Try&rev=4f50a949b7df
Assignee | ||
Comment 13•12 years ago
|
||
Hm, so all three of the suspected patches on comment 10 went green on their own. I'm going to divide these up, start getting them reviewed, and focus on landing them individually to sort out the wackiness and decrease regression potential.
Assignee | ||
Comment 14•12 years ago
|
||
Moving deps up a few levels.
Comment 15•12 years ago
|
||
All the blocking bugs here have been fixed, but there are still some places that need to be fixed up. See bug 770840 comment 4.
Updated•11 years ago
|
Flags: needinfo?(josh)
Assignee | ||
Comment 17•9 years ago
|
||
We assert against this now.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•