773610 - Fix consumers that AddRef XPCWrappedJS off-main-thread

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Split off from bug 771074.

Comment 1

[Bobby Holley (:bholley)]

Fixed various consumers and pushed to try with fatal asserts. Let's see what our test suite hits:

https://tbpl.mozilla.org/?tree=Try&rev=7d5f0d9086ab

Comment 2

[Bobby Holley (:bholley)]

Fixed more and pushed again:
https://tbpl.mozilla.org/?tree=Try&rev=c3b0a1617a2a

Comment 3

[Bobby Holley (:bholley)]

More:
https://tbpl.mozilla.org/?tree=Try&rev=284f144555bc

Comment 4

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=2aa5bfd373d8

Comment 5

[Bobby Holley (:bholley)]

Note that my patches are in a github branch here:  https://github.com/bholley/mozilla-central/commits/wrappedjs_dethread

Comment 6

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=aab9110a1fdf

Comment 7

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=0d1e656367ce

Comment 8

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #7)
> https://tbpl.mozilla.org/?tree=Try&rev=0d1e656367ce

Nice, linux is green! It's pretty likely that there are going to be some platform-specific failures here, so let's check those now:

https://tbpl.mozilla.org/?tree=Try&rev=b753c766c5ef

Comment 9

[Bobby Holley (:bholley)]

This is hitting an out-of-bounds nsTArray on windows that MOZ_ASSERTs before we get a stack. I replaced it with an NS_ASSERTION, which should hopefully dump a stack:

https://tbpl.mozilla.org/?tree=Try&rev=1bed20aef921

Comment 10

[Bobby Holley (:bholley)]

Ugh, the stacks here are being supremely unhelpful, and this doesn't reproduce locally for me.

I'm pretty sure it's related to one of the three patches that do something with nsTArray, so I'm pushing those three separately to try to see if we can get some more data:

https://tbpl.mozilla.org/?tree=Try&rev=1ff159e0aae5
https://tbpl.mozilla.org/?tree=Try&rev=e8bd699b2ce6
https://tbpl.mozilla.org/?tree=Try&rev=8193765f4429

Comment 11

[Bobby Holley (:bholley)]

I'm starting to think that the issue here might just be that nsTArray asserts against out-of-bounds access but nsCOMArray doesn't. Let's test that theory:

https://tbpl.mozilla.org/?tree=Try&rev=2795f3a43e11

Comment 12

[Bobby Holley (:bholley)]

@#$% warnings-as-errors - https://tbpl.mozilla.org/?tree=Try&rev=4f50a949b7df

Comment 13

[Bobby Holley (:bholley)]

Hm, so all three of the suspected patches on comment 10 went green on their own. I'm going to divide these up, start getting them reviewed, and focus on landing them individually to sort out the wackiness and decrease regression potential.

Comment 14

[Bobby Holley (:bholley)]

Moving deps up a few levels.

Comment 15

[Andrew McCreight [:mccr8] (PTO until 12-2)]

All the blocking bugs here have been fixed, but there are still some places that need to be fixed up.  See bug 770840 comment 4.

Comment 16

[Josh Matthews [:jdm]]

Just making sure I don't lose track of this.

Comment 17

[Bobby Holley (:bholley)]

We assert against this now.