873809 - Bug 870856 and bug 872338 needed a clobber on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

I wasn't entirely sure about https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1196b497640b where I had already set a clobber for something else (to be named later, once I remember what it was), so the retriggers didn't have any choice but to be clobbers, so I merged it around just to see what would happen.

https://tbpl.mozilla.org/?onlyunstarred=1&rev=317fe0f314ab says what would happen is that it would burn the same way again,

https://tbpl.mozilla.org/php/getParsedLog.php?id=23120848&tree=Mozilla-Central

No rule to make target 'nsIDOMDOMError.idl' needed by ['<command-line>', 'nsIDOMDOMError.idl']

Which in fact reminds me of what else, bug 872338 which I backed out over

https://tbpl.mozilla.org/php/getParsedLog.php?id=23103300&tree=Mozilla-Inbound

No rule to make target 'nsIAccessibleCursorable.idl' needed by ['<command-line>', 'nsIAccessibleCursorable.idl']

Comment 1

[Phil Ringnalda (:philor)]

And again in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ca5b29e91b

Comment 2

[Phil Ringnalda (:philor)]

Which is sort of strange without context, since that's actually from https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=90b73c3533fd

Comment 3

[Gregory Szorc [:gps]]

This is a regression from bug 848530. I have a tested patch and hope I can find a reviewer so we don't have to back out bug 848530.

Comment 4

[Gregory Szorc [:gps]]

Attachment: Proper dependencies under pymake, v1

Tagging all build peers. Whoever gets it first.

For whatever reason, pymake's includedeps isn't working here. So, I reverted to regular include. It seems to be fast enough. The path normalization may not be necessary, but it can't hurt.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e6f9a789727

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e6f9a789727