Closed
Bug 873809
Opened 12 years ago
Closed 12 years ago
Bug 870856 and bug 872338 needed a clobber on Windows
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: philor, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.02 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I wasn't entirely sure about https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1196b497640b where I had already set a clobber for something else (to be named later, once I remember what it was), so the retriggers didn't have any choice but to be clobbers, so I merged it around just to see what would happen.
https://tbpl.mozilla.org/?onlyunstarred=1&rev=317fe0f314ab says what would happen is that it would burn the same way again,
https://tbpl.mozilla.org/php/getParsedLog.php?id=23120848&tree=Mozilla-Central
No rule to make target 'nsIDOMDOMError.idl' needed by ['<command-line>', 'nsIDOMDOMError.idl']
Which in fact reminds me of what else, bug 872338 which I backed out over
https://tbpl.mozilla.org/php/getParsedLog.php?id=23103300&tree=Mozilla-Inbound
No rule to make target 'nsIAccessibleCursorable.idl' needed by ['<command-line>', 'nsIAccessibleCursorable.idl']
Reporter | ||
Comment 1•12 years ago
|
||
Severity: normal → critical
Reporter | ||
Comment 2•12 years ago
|
||
Which is sort of strange without context, since that's actually from https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=90b73c3533fd
Assignee | ||
Comment 3•12 years ago
|
||
This is a regression from bug 848530. I have a tested patch and hope I can find a reviewer so we don't have to back out bug 848530.
Assignee | ||
Comment 4•12 years ago
|
||
Tagging all build peers. Whoever gets it first.
For whatever reason, pymake's includedeps isn't working here. So, I reverted to regular include. It seems to be fast enough. The path normalization may not be necessary, but it can't hurt.
Attachment #751502 -
Flags: review?(ted)
Attachment #751502 -
Flags: review?(mh+mozilla)
Attachment #751502 -
Flags: review?(khuey)
Attachment #751502 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #751502 -
Flags: review?(ted)
Attachment #751502 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 6•12 years ago
|
||
Target Milestone: --- → mozilla24
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•