873812 - Trying to establish a call from an Android device to a Windows machine fails to render the remote video streams

Status: VERIFIED FIXED

Description

[Jason Smith [:jsmith]]

Build: Firefox Nightly 24
Desktop OS: Windows 7 64-bit
Android Device: Samsung Galaxy Nexus
Android OS: Android 4.2

STR

1. Go to apprtc.appspot.com on FxAndroid
2. Go to the URL derived from #1 on apprtc on a desktop machine
3. Accept permissions on your desktop machine

Expected

The remote camera stream should render - desktop should see the Android video, android should see the desktop video.

Actual

The remote camera stream fails to render.

Additional Notes:

Interestingly enough, I did confirm the call was established - I was able to send and receive audio across my Android and desktop device. So something isn't working correctly with the video streams then.

Comment 1

[Jason Smith [:jsmith]]

Attachment: NSPR Windows

Comment 2

[Jason Smith [:jsmith]]

Attachment: Android Logcat

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Same problem as on the mobile demo pages (https://webrtc-demo.vcap.mozillalabs.com/mobile.html):

05-18 19:16:42.274: D/WEBRTC(9185): VideoCaptureDeviceInfoAndroid
05-18 19:16:42.274: D/WEBRTC(9185): Camera 0, Facing back, Orientation 90
05-18 19:16:42.274: W/CameraService(129): CameraService::connect X (pid 9185) rejected (existing client).
05-18 19:16:42.274: E/WEBRTC(9185): Failed to init VideoCaptureDeviceInfo exception: Fail to connect to camera service
05-18 19:16:42.274: D/WEBRTC(9185): Failed to create VideoCaptureDeviceInfoAndroid.
05-18 19:16:42.274: D/WEBRTC(9185): VideoCaptureDeviceInfoAndroid
05-18 19:16:42.282: D/WEBRTC(9185): Camera 0, Facing back, Orientation 90
05-18 19:16:42.282: W/CameraService(129): CameraService::connect X (pid 9185) rejected (existing client).
05-18 19:16:42.282: E/WEBRTC(9185): Failed to init VideoCaptureDeviceInfo exception: Fail to connect to camera service
05-18 19:16:42.282: D/WEBRTC(9185): Failed to create VideoCaptureDeviceInfoAndroid.

After fixing Bug 863290, trying to probe the Video Capture capabilities no longer silently fails. From a quick read, calling SetAndroidObjects causes a VideoCaptureDeviceInfoAndroid object to be constructed, and that tries to get camera capability info on construction, which fails when someone already has the camera locked.

The webrtc-Android code architecture needs some work here...

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Don't set Android objects more than once.

Simple fix suggestion by jesup: just bail out of SetAndroidObjects early if the objects are already set up.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf78a5b36a96

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf78a5b36a96

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 751685 [details] [diff] [review]
Patch 1. Don't set Android objects more than once.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 750010 and friends
User impact if declined: Failure to get video when trying to use WebRTC
Testing completed (on m-c, etc.): Landed on m-c a few days ago. Doesn't solve all crashes but fixes reall bugs.
Risk to taking this patch (and alternatives if risky): Don't care about WebRTC stability for 23. Little risk, change in preffed-off feature.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3bacaedcbba9

Comment 10

[Jason Smith [:jsmith]]

Looks like I still can't get a call to work between FxAndroid and Desktop Firefox. I'll file a new bug on this.