Closed
Bug 873812
Opened 10 years ago
Closed 10 years ago
Trying to establish a call from an Android device to a Windows machine fails to render the remote video streams
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
VERIFIED
FIXED
mozilla24
People
(Reporter: jsmith, Assigned: gcp)
References
Details
(Keywords: regression, reproducible, Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+])
Attachments
(3 files)
192.37 KB,
text/plain
|
Details | |
86.15 KB,
text/plain
|
Details | |
1.43 KB,
patch
|
jesup
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Build: Firefox Nightly 24 Desktop OS: Windows 7 64-bit Android Device: Samsung Galaxy Nexus Android OS: Android 4.2 STR 1. Go to apprtc.appspot.com on FxAndroid 2. Go to the URL derived from #1 on apprtc on a desktop machine 3. Accept permissions on your desktop machine Expected The remote camera stream should render - desktop should see the Android video, android should see the desktop video. Actual The remote camera stream fails to render. Additional Notes: Interestingly enough, I did confirm the call was established - I was able to send and receive audio across my Android and desktop device. So something isn't working correctly with the video streams then.
Reporter | ||
Updated•10 years ago
|
Blocks: android-webrtc
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+]
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Assignee | ||
Comment 3•10 years ago
|
||
Same problem as on the mobile demo pages (https://webrtc-demo.vcap.mozillalabs.com/mobile.html): 05-18 19:16:42.274: D/WEBRTC(9185): VideoCaptureDeviceInfoAndroid 05-18 19:16:42.274: D/WEBRTC(9185): Camera 0, Facing back, Orientation 90 05-18 19:16:42.274: W/CameraService(129): CameraService::connect X (pid 9185) rejected (existing client). 05-18 19:16:42.274: E/WEBRTC(9185): Failed to init VideoCaptureDeviceInfo exception: Fail to connect to camera service 05-18 19:16:42.274: D/WEBRTC(9185): Failed to create VideoCaptureDeviceInfoAndroid. 05-18 19:16:42.274: D/WEBRTC(9185): VideoCaptureDeviceInfoAndroid 05-18 19:16:42.282: D/WEBRTC(9185): Camera 0, Facing back, Orientation 90 05-18 19:16:42.282: W/CameraService(129): CameraService::connect X (pid 9185) rejected (existing client). 05-18 19:16:42.282: E/WEBRTC(9185): Failed to init VideoCaptureDeviceInfo exception: Fail to connect to camera service 05-18 19:16:42.282: D/WEBRTC(9185): Failed to create VideoCaptureDeviceInfoAndroid. After fixing Bug 863290, trying to probe the Video Capture capabilities no longer silently fails. From a quick read, calling SetAndroidObjects causes a VideoCaptureDeviceInfoAndroid object to be constructed, and that tries to get camera capability info on construction, which fails when someone already has the camera locked. The webrtc-Android code architecture needs some work here...
Reporter | ||
Updated•10 years ago
|
Keywords: regression
Assignee | ||
Comment 4•10 years ago
|
||
Simple fix suggestion by jesup: just bail out of SetAndroidObjects early if the objects are already set up.
Attachment #751685 -
Flags: review?(rjesup)
Updated•10 years ago
|
Attachment #751685 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf78a5b36a96
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf78a5b36a96
Assignee: nobody → gpascutto
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•10 years ago
|
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 751685 [details] [diff] [review] Patch 1. Don't set Android objects more than once. [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 750010 and friends User impact if declined: Failure to get video when trying to use WebRTC Testing completed (on m-c, etc.): Landed on m-c a few days ago. Doesn't solve all crashes but fixes reall bugs. Risk to taking this patch (and alternatives if risky): Don't care about WebRTC stability for 23. Little risk, change in preffed-off feature.
Attachment #751685 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #751685 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3bacaedcbba9
Updated•10 years ago
|
Reporter | ||
Comment 10•10 years ago
|
||
Looks like I still can't get a call to work between FxAndroid and Desktop Firefox. I'll file a new bug on this.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Reporter | ||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•