873945 - [B2G][Marketplace]system locale changes not applied to market place application

Status: RESOLVED INVALID

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Leo]

STR:
1. Set system language to anything other than English.

Actual:
1. The strings used in Marketplace will be displayed in English.

Expected:
1. All the strings should be localized to the system Language.

Reproducibility: 100%
Gaia-branch: gaia/master
Gaia revision: af15e30051af05a150d85fbe29e5fa9b6bbc2570

Comment 1

[Leo]

Please let know if this is a part of design or if we are planning to localize this application.

Comment 2

[Jason Smith [:jsmith]]

My guess is this is a problem where marketplace isn't detecting when the system's language changes while installed as an app.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

By design, when you change your language in Gaia's settings you have to relaunch the Marketplace for changes to take effect.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> By design, when you change your language in Gaia's settings you have to
> relaunch the Marketplace for changes to take effect.

FWIW, it's technically possible to switch languages during runtime. You would need to watch for the visibility change event to know when you come back into the foreground.

Are we sure this doesn't reproduce in case where the app was killed and started again?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> > By design, when you change your language in Gaia's settings you have to
> > relaunch the Marketplace for changes to take effect.
> 
> FWIW, it's technically possible to switch languages during runtime. You
> would need to watch for the visibility change event to know when you come
> back into the foreground.

I know, yeah - the Marketplace used to have it pre-Fireplace days. (Bug 844964.) Basta can shed some technical light on why we don't anymore.

> Are we sure this doesn't reproduce in case where the app was killed and
> started again?

If your language is not supported by the Marketplace, we fall back to English.

https://github.com/mozilla/fireplace/blob/master/hearth/media/js/l10n.js#L3

For a supported locale, I have never seen it not be localized upon relaunch.

Comment 6

[Matt Basta [:basta]]

(In reply to Jason Smith [:jsmith] from comment #4)
> FWIW, it's technically possible to switch languages during runtime. You
> would need to watch for the visibility change event to know when you come
> back into the foreground.

We don't presently download language packs that don't apply to the user (that's a lot of wasted bandwidth for the vast majority of users). Until we become a true packaged app (dependent on Persona authenticating against the app:// URL scheme), we can't support this. This functionality will likely not ever be supported in the Marketplace when accessed by the browser, and is unlikely to be fully supported by the Marketplace as an app because of technical restrictions and the edge-caseyness of this issue.

Note also that Gaia has the same issue with certain aspects of the UI. Language changes do not take effect system-wide until the device is restarted.

When the app is cold-started, we run through a manual process of detecting language and mapping that to a supported locale, which is then loaded before we load the JS for the Marketplace.

Leo: Can you reproduce this issue on a cold start?

Comment 7

[Leo]

(In reply to Matt Basta [:basta] from comment #6)
> When the app is cold-started, we run through a manual process of detecting
> language and mapping that to a supported locale, which is then loaded before
> we load the JS for the Marketplace.
> 
> Leo: Can you reproduce this issue on a cold start?

I have tried the following steps with two different locale, but still the locale is not applied
1. Set the system language to spanish/portugese in settings.
2. Restart the device.
3. Launch the market place application.

The application still uses English as the Locale.

By checking the link in comment #5, I believe spanish and portugese is supported. Please let me know if any more information is required.

Comment 8

[krupa raj[:krupa]]

Attachment: screenshot

I am 1.0.1 and I see the changes get applied. Note that with fireplace not all strings are localized. See screenshot- the categories are localized.

Comment 9

[Matt Basta [:basta]]

(In reply to Leo from comment #7)
> I have tried the following steps with two different locale, but still the
> locale is not applied
> 1. Set the system language to spanish/portugese in settings.

We do not currently have Portuguese translations for Marketplace strings. We have been waiting on these for a while and they have not come through yet.

(In reply to krupa raj 82[:krupa] from comment #8)
> Created attachment 752255 [details]
> screenshot
> 
> I am 1.0.1 and I see the changes get applied. Note that with fireplace not
> all strings are localized. See screenshot- the categories are localized.

This is because the localizers have not translated the post-redesign strings. Many of the new strings from the redesign have not been translated yet.


Since there's nothing inherently wrong with the Marketplace or the logic in it, I'm going to close this bug and follow up with Wil offline to see what we can do about getting new strings. Last I checked, Wil was trying to get khan updated with a new version of nodejs so he could run the string extraction tool.

Comment 10

[Leo]

Please let us know if we have any expected date to see portugese locale changes on device?

Comment 11

[Matt Basta [:basta]]

I have no idea. We don't have translations from the localizers for Portuguese yet. They'll land the Thursday after we get the translated strings.