87415 - Supplement 'review' keyword with 's-review' for super-review needs

Status: VERIFIED WONTFIX

(bugzilla.mozilla.org :: Administration, task)

Description

[James Green]

Right now we have two keywords for two levels of checking before code may be
checked in. However we have up to three levels of checking:

- Review (keyword: 'review')
- Super-review (need 's-review' keyword)
- Approval (keyword: 'approval')

I propose we add an 's-review' keyword for bugs that require a super-reviewer to
examine and authorise as a high-quality patch. I say 's-review' rather than
'sreview' since it's not as easy to mix or mistype them.

This would also eliminate the need for developers to put information about
what's needed in the status line, which tends to be a per-developer syntax and
thus not reliably searched on.

Comment 1

[Asa Dotzler [:asa]]

wontfix.  we'll soon have an attachment status which will solve most of the
problems we have with patch, review and approval keywords.

Comment 2

[timeless]

vrfy wontfix fwiw the patch tracker is bug 84338