Open
Bug 874381
Opened 11 years ago
Updated 2 years ago
[meta][SessionStore] Clean up and document session restore
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
NEW
People
(Reporter: Yoric, Unassigned)
References
(Depends on 3 open bugs)
Details
(Keywords: addon-compat, meta)
The state of Session Restore contains a number of fragile and undocumented fields. Opening this bug to track cleanups.
Reporter | ||
Updated•11 years ago
|
Keywords: addon-compat
Comment 1•11 years ago
|
||
Some "__SS_*" properties still there. * window.__SSi * window.__SS_restoreID * window.__SS_tabsToRestore * window.__SS_lastSessionWindowID * tab.linkedBrowser.__SS_restore_data * tab.linkedBrowser.__SS_restore_pageStyle * tab.linkedBrowser.__SS_restore_tab * tab.linkedBrowser.__SS_formDataSaved * tab.linkedBrowser.__SS_hostSchemeData * tab.linkedBrowser.__SS_broken_history * tab.linkedBrowser.__SS_extdata * tab.linkedBrowser.__SS_shistoryListener Are there existing bugs for them?
Comment 2•11 years ago
|
||
My addon uses windows.__SSi to match session data to it's associated window. If that is removed, there should be some way to still get that value.
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to YUKI "Piro" Hiroshi from comment #1) > Some "__SS_*" properties still there. We'll open bugs progressively. (In reply to Michael Kraft [:morac] from comment #2) > My addon uses windows.__SSi to match session data to it's associated window. > If that is removed, there should be some way to still get that value. I don't understand your sentence. What are you matching, exactly? Note that __SSi will not disappear immediately – actually, it might be the last one to disappear.
Comment 4•11 years ago
|
||
(In reply to David Rajchenbach Teller [:Yoric] from comment #3) > I don't understand your sentence. What are you matching, exactly? > Note that __SSi will not disappear immediately – actually, it might be the > last one to disappear. I use it as a window identifier since it's always set and unique, in addition to matching Windows to window session data. I suppose I can create my own unique window identifier though.
Reporter | ||
Comment 5•11 years ago
|
||
In our various patches, we are using WeakMap for this kind of use. Would this work for you, morac?
Comment 6•11 years ago
|
||
(In reply to David Rajchenbach Teller [:Yoric] from comment #5) > In our various patches, we are using WeakMap for this kind of use. Would > this work for you, morac? As long as it's readable and set and cleared properly, that will work.
Comment 7•11 years ago
|
||
(In reply to Michael Kraft [:morac] from comment #6) > (In reply to David Rajchenbach Teller [:Yoric] from comment #5) > > In our various patches, we are using WeakMap for this kind of use. Would > > this work for you, morac? > > As long as it's readable and set and cleared properly, that will work. I think David was saying that you might want to look into using this inside your add-on to map data to windows. We might end up using this in SessionStore too but we would not want to expose it unless really necessary.
Comment 8•11 years ago
|
||
Anyway, please let's not turn this into a discussion forum. This is a meta bug for tracking progress. Once we attack __SSi we can deal with details in the specific bug and can handle bigger discussions on the mailing lists.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•