874394 - Test failure in '/testAwesomeBar/testPasteLocationBar.js' due to the urlbar-container not being found

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Daniela Petrovici]

The test: /testAwesomeBar/testPasteLocationBar.js fails on all OS with Australis build 

Fails due to line: http://hg.mozilla.org/qa/mozmill-tests/file/05730582186d/lib/toolbars.js#l18

URLBAR_CONTAINER needs to contain: 'id("nav-bar-customizationtarget")' since this is the element that contains the urlbar-container. The line should be changed to:
const URLBAR_CONTAINER = '/id("main-window")/id("tab-view-deck")/[0]' +
                         '/id("navigator-toolbox")/id("nav-bar")/id("nav-bar-customizationtarget")/id("urlbar-container")';

NOTE: The changing of the line should be done only if nodeCollector cannot be used instead of the Lookup expression

Comment 1

[Daniela Petrovici]

This change is intentional due per bug 864355 where almost all nav-bar needs to be included under the customization target.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bug 864355 is about a different thing, and I don't see the connection to this failure. Here we simply have a new container around the navbar items.

Comment 3

[Daniela Petrovici]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Bug 864355 is about a different thing, and I don't see the connection to
> this failure. Here we simply have a new container around the navbar items.

The new container around the navbar items was introduced in bug 864355. Please see attached patch for that bug that landed as: https://hg.mozilla.org/projects/ux/rev/7105d3282462. The failure in this bug appears because we cannot find the element (due to the container around the navbar). 

Based on bug 874341 comment #6, we needed to figure out if these changes are intentional or not, but we still need to figure out if nodeCollector can be used instead of Lookup expression here.

Comment 4

[mario garbi]

Testcase as requested in Ask an Expert meeting:

Steps:
1.Open ../data/awesomebar/copypaste.html
2.Select a piece of text
3.Copy in clipboard the selected text
4.Select and clear the locationBar 
5.Rightclick on the locationBar to bring up the contextMenu
6.Select "Paste" from the contextMenu
7.Check that the text copied correctly to the locationBar

I managed to get the nodes up to ".box-inherit scrollbox-innerbox" but we can't seem to gather the menuItems ("cmd", "cmd_paste").

Comment 5

[Andrei Eftimie]

I think a running testcase was asked for.
As in a js file that you can run with mozmill.

Comment 6

[mario garbi]

Attachment: test file

The autonomous test that copies a text and tries to paste it in the location bar using the context menu.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 773984 [details]
test file

Please do not ask for review on a temporary test. If you want immediate feedback raise the needinfo flag. Also make sure that you attach tests as text/plain.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't know either. nodeCollector just has a wrapper around getAnonymousElementByAttribute. So you might want to get in touch with the developer as usual under those conditions.

http://hg.mozilla.org/mozilla-central/annotate/79439df5bf5d/browser/base/content/urlbarBindings.xml#l70

Comment 9

[mario garbi]

The patch for 874393 will introduce new library elements that are needed for this bug, therefore I will set it dependent of that.

Comment 10

[mario garbi]

Attachment: australis_toolbar.patch

This patch handles the Australis node once we land the blocker 874393 that introduces the library elements.

Comment 11

[mario garbi]

Comment on attachment 779217 [details] [diff] [review]
australis_toolbar.patch

I removed the review request as I needed to make a few small changes to it, I will reupload a patch with reports as soon as possible today.

Comment 12

[mario garbi]

Attachment: australis_toolbar_2407.patch

This patch adds an utils function to the Lookup that handles the Australis builds properly. 

Mac:
Nightly
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb956a
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cc3907

UX
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb0197
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb099c

Linux:
Nightly
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb6ed8
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb58a2

UX
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb2d8d
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb0785

WinXP:
Nightly
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb0e88
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb01b0

UX
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb352d
http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d61cb4cd5

Comment 13

[mario garbi]

Comment on attachment 780388 [details] [diff] [review]
australis_toolbar_2407.patch

I will add the fix patch for both of them in Bug 874395.

Comment 14

[Andreea Matei [:AndreeaMatei]]

This was fixed now in bug 874395.